Skip to content

PMM-7 Clean up unused code #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ademidoff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PMM-7 Clean up unused code #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2f765
PMM-7 Clean up unused code
ademidoff Aug 7, 2026
7480655
Merge branch 'main' into PMM-7-cleanup-unused-auth-methods
ademidoff Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ jobs:
run: |
make gen

- name: Generate Go code
run: make gen-code

- name: Run tests
run: |
go clean -testcache
Expand Down
6 changes: 1 addition & 5 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ Shared Go module (`github.com/percona/platform`) providing:
- **Generated Go code** from those protos (under `gen/`, committed to the repo)
- **Shared Go libraries** consumed across all platform services (under `pkg/`)

The sibling repo `github.com/percona/saas` is a public mirror — `make saas` extracts a subset of this repo there, rewriting all import paths.

---

## Directory structure
Expand Down Expand Up @@ -46,14 +44,12 @@ Mirrors `api/` structure. Regenerate with `make gen`.
make init # Build all dev tools into bin/ (run once after checkout)
make gen # Regenerate all protobuf code (rm -rf gen, buf generate, format, breaking check)
make descriptors # Update platform.bin used for breaking-change detection (run before make gen when removing protos)
make gen-code # go generate + go install
make format # gofumpt + goimports + buf format
make check # go-consistent + golangci-lint
make test # go test -race ./...
make test-cover # Per-package coverage → cover.out
make test-crosscover # Cross-package coverage → crosscover.out
make swagger-ui # Serve Swagger docs locally on :8081 (Docker required)
make saas # Extract public subset to ../saas with import path rewrite
```

---
Expand Down Expand Up @@ -92,5 +88,5 @@ Generated code is **committed to the repo**.

## CI

- **ci.yml**: on push to `main` and all PRs — runs `make gen`, `make gen-code`, cross-coverage tests, then `make format` + `make check` with reviewdog annotations on PRs
- **ci.yml**: on push to `main` and all PRs — runs `make gen`, cross-coverage tests, then `make format` + `make check` with reviewdog annotations on PRs
- **Verification step**: CI asserts no uncommitted source changes after gen (go.sum tidying is the only allowed diff)
7 changes: 0 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ gen: ## Format, check, and generate code u
make format
bin/buf breaking --against platform.bin api

gen-code: ## Generate code
go generate ./...
go install ./...

swagger-ui: ## Serve API documentation with SwaggerUI
docker run -p 8081:8080 -e URLS='[ \
{name:"telemetryd", url:"/gen/telemetry/reporter/reporter_api.swagger.json"}, \
Expand All @@ -47,7 +43,4 @@ test-crosscover: ## Run tests and collect cross-packag
descriptors: ## Update files used for breaking changes detection
bin/buf build -o platform.bin --as-file-descriptor-set api

saas: ## Extract public APIs and generated files into ../saas
go run post-processing.go -project saas

.PHONY: $(MAKECMDGOALS)
Loading