PMM-7 Clean up unused code - #1249
Open
ademidoff wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all code and configuration related to the "saas" public mirror extraction and the
make gen-codetarget, simplifying the repository and CI process. It also removes theauth_interceptor.goauthentication interceptors and associated helpers, which are no longer used.Major removals and simplification:
saasmirror have been deleted, including thepost-processing.goscript and themake saasMakefile target. (post-processing.go,Makefile,CLAUDE.md)make gen-codeMakefile target, its invocation in CI, and related documentation have been removed. Code generation is now handled solely bymake gen. (Makefile,.github/workflows/ci.yml,CLAUDE.md)Authentication code cleanup:
pkg/servers/auth_interceptor.gofile has been significantly reduced, removing the unary and stream gRPC authentication interceptors and all related helper functions and types that are no longer in use. (pkg/servers/auth_interceptor.go)Documentation updates:
make gen-code,make saas, and the saas mirror process have been removed fromCLAUDE.mdto match the codebase changes. (CLAUDE.md)These changes streamline the repository by removing unused infrastructure, making the build, test, and CI processes simpler and easier to maintain.