hotfix(step-up): stop prompting where the flow already proves the passkey#2515
Conversation
withdraw/prepare is followed by the admin EIP-712 the passkey must sign, and session-approve's payload is itself a passkey enable signature — the step-up assertion before them proved nothing extra and turned every collateral-funded send into three fingerprint prompts (the triple-prompt reports). PAN/CVV/PIN and bank-add keep step-up: there the cookie is the only proof. Pairs with peanut-api-ts dropping requireStepUp from the same routes; backend deploys first (enforcement would 401 clients that stop sending the header).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRain withdrawal preparation and session approval requests no longer enable step-up/WebAuthn. Their documentation now identifies the subsequent passkey-derived signature as the authentication step. ChangesRain withdrawal authentication flow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
Code-analysis diffPainscore total: 6270.06 → 6270.18 (+0.12) 🆕 New findings (2)
✅ Resolved (2)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
FE half of peanutprotocol/peanut-api-ts#1241 — removes
stepUp: truefromprepareWithdrawalandsubmitWithdrawSessionApproval. These flows are self-proving (admin EIP-712 / enable signature follow immediately from the same passkey), so the step-up assertion added by #2463 only added a third fingerprint sheet to every collateral-funded send (the triple-prompt reports from Hugo and Jota, confirmed on-chain: the send tx carries exactly 2 WebAuthn signatures).Card PAN/CVV/PIN and bank-account add keep step-up.
Risks / breaking changes
STEP_UP_ENFORCEDis on and this ships before the BE drops the gate, withdraw prepare would 401.QA
Screenshots: N/A (no UI change — prompt-count behavior only)
Hotfix to
main(production user-visible triple-prompt). Supersedes #2514 (dev-targeted). Deploy order: peanut-api-ts hotfix first. Back-merge main→dev after merge.Summary by CodeRabbit