fix(step-up): stop prompting where the flow already proves the passkey#2514
fix(step-up): stop prompting where the flow already proves the passkey#2514jjramirezn wants to merge 1 commit into
Conversation
withdraw/prepare is followed by the admin EIP-712 the passkey must sign, and session-approve's payload is itself a passkey enable signature — the step-up assertion before them proved nothing extra and turned every collateral-funded send into three fingerprint prompts (the triple-prompt reports). PAN/CVV/PIN and bank-add keep step-up: there the cookie is the only proof. Pairs with peanut-api-ts dropping requireStepUp from the same routes; backend deploys first (enforcement would 401 clients that stop sending the header).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6267.93 → 6268.05 (+0.12) 🆕 New findings (2)
✅ Resolved (2)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
|
Superseded by hotfix #2515 (targets main). dev gets it via back-merge. |
Summary
FE half of peanutprotocol/peanut-api-ts#1241 — removes
stepUp: truefromprepareWithdrawalandsubmitWithdrawSessionApproval. These flows are self-proving (admin EIP-712 / enable signature follow immediately from the same passkey), so the step-up assertion added by #2463 only added a third fingerprint sheet to every collateral-funded send (the triple-prompt reports from Hugo and Jota, confirmed on-chain: the send tx carries exactly 2 WebAuthn signatures).Card PAN/CVV/PIN and bank-account add keep step-up.
Risks / breaking changes
STEP_UP_ENFORCEDis on and this ships before the BE drops the gate, withdraw prepare would 401.QA
Screenshots: N/A (no UI change — prompt-count behavior only)