Skip to content

Enable CI tests to fail when test commands fail #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jafingerhut wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Enable CI tests to fail when test commands fail #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
54bd318
Whitespace-only change to exercise CI tests
jafingerhut Sep 12, 2026
6ac5cf2
Merge branch 'main' into whitespace-only-to-test-build-v2
jafingerhut Sep 12, 2026
c1e692a
Changes intended to make the failing test in CI fail the CI as a whole
jafingerhut Sep 13, 2026
3876ede
Undo whitespace-only changes
jafingerhut Sep 13, 2026
7cd4fbb
Try disabling valgrind use during PI testing
jafingerhut Sep 13, 2026
f002c32
Try unset'ing the env variable instead of assigning it 0
jafingerhut Sep 13, 2026
315baf9
Extra debug cmds
jafingerhut Sep 13, 2026
602455f
Update googletest to tag v1.15.2 dated 2024-Jul-31
jafingerhut Sep 14, 2026
fff55bc
Remove some extra debug cmds. With new googletest version, try valgr…
jafingerhut Sep 14, 2026
c243413
Disable use of valgrind tests again.
jafingerhut Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Run tests
run: |
docker run -w /PI pi bash -c \
'uv run make check -j2 || (find . -name "test-suite.log" | xargs cat)'
'ec=0; uv run make check -j2 || ec=$?; (find . -name "test-suite.log" | xargs cat); exit $ec'
# Comment this out until and unless we make it pass.
# - name: Check style
# run: |
Expand Down
2 changes: 1 addition & 1 deletion proto/tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ACLOCAL_AMFLAGS = ${ACLOCAL_FLAGS} -I m4

# for deprecated Protobuf fields
AM_CXXFLAGS += -Wno-error=deprecated-declarations
AM_CXXFLAGS += -Wno-error=deprecated-declarations -Wno-error=unused-function

# issytem for generated code, to avoid potential warnings
AM_CPPFLAGS = \
Expand Down
2 changes: 1 addition & 1 deletion tests/CLI/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

ACLOCAL_AMFLAGS = ${ACLOCAL_FLAGS} -I m4

AM_TESTS_ENVIRONMENT = export PI_TEST_WITH_VALGRIND=1;
AM_TESTS_ENVIRONMENT = unset PI_TEST_WITH_VALGRIND;

TESTS = \
table_dump.test \
Expand Down
2 changes: 1 addition & 1 deletion third_party/googletest
Open in desktop
Submodule googletest updated 365 files