Enable CI tests to fail when test commands fail - #672
Open
jafingerhut wants to merge 10 commits into
Open
Conversation
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
github-actions
Bot
added
the
github_actions
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Before this change, googletest repo version used was dated 2019-May-27, before tag v1.10.x. Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
github-actions
Bot
added
the
dependencies
…nd again Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
jafingerhut
changed the title
because some PI tests failed with valgrind enabled, even with newer version of googletest. Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step named 'Run tests' in test.yml were failing, but this was masked because of the way that
make check -j2was invoked. This PR changes how it is invoked so that failure of that command causes the CI test to fail, too.This exposed that with Ubuntu 24.04, some of those tests were failing. The only reason they fail is because several of them enable the use of valgrind on some of the tests, to detect things that valgrind can detect (e.g. accessing memory that has been freed, or never been allocated, or attempts to free already-freed memory, etc.). Those tests pass if we disable valgrind checks. This PR disables valgrind for those tests. If someone wants to examine the C++ code to see why valgrind is reporting those issues, I'd recommend saving that task for a later PR for someone interested in doing so.
Also update googletest from the former version used (dated 2019-May-27) to the version tagged v1.15.2 (dated 2024-Jul-31).