feat(notifications): detect-and-warn when Windows notifications are off + test button#18
Merged
Merged
Conversation
…est button Windows' per-app/system notification toggle being OFF silently drops toasts (.show() returns Ok, nothing appears) with no way for users to tell. - get_notification_status command queries WinRT ToastNotifier.Setting (enabled / disabledForApplication / disabledForUser / disabledByGroupPolicy / disabledByManifest). Adds the windows crate UI_Notifications feature (already in the dep tree). - NotificationBanner.tsx shows an inline warning that deep-links to ms-settings:notifications when disabled; re-checks on window focus. Rendered on the Alerts page and in Settings. - 'Send test notification' button in Settings → Desktop Notifications card calls the existing send_desktop_notification command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows' per-app / system notification toggle being OFF silently drops toasts —
Toast::show()returnsOkbut nothing appears, and users can't tell their alerts are being swallowed.Backend
get_notification_statuscommand queries WinRTToastNotificationManager::CreateToastNotifierWithId(aumid).Setting()→enabled/disabledForApplication/disabledForUser/disabledByGroupPolicy/disabledByManifest(unknownfallback). Non-Windows builds returnenabled.windowscrateUI_Notificationsfeature (the crate is already in the tree viatauri-winrt-notification, so no second copy).Frontend
NotificationBanner.tsx: inline amber warning shown only when disabled — "Windows notifications are off for OverManager — desktop alerts won't appear" — with a button that deep-links toms-settings:notifications. Re-checks on window focus so it clears once the user flips the toggle back on. Rendered on the Alerts page and in Settings.send_desktop_notification.Verification
cargo check✅ (WinRT path resolves → feature active) ·npx tsc --noEmit✅