fix(cloud): enable keyring native backends so credentials persist#16
Merged
Conversation
keyring 3.x with no backend feature silently uses an in-memory mock store, so cloud login never survived an app restart. Enable the platform-native backends (windows-native, apple-native, sync-secret-service) so credentials land in the OS keychain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
keyring = "3"with no backend feature → keyring 3.x silently uses an in-memory mock store, so cloud login does not survive an app restart (re-login every launch).Fix
One-line
Cargo.tomlchange enabling the platform-native backends:The save/load/restore code (
cloud/auth.rsservicepopmanager-cloud, restore block inlib.rs) was already correct and wired.Verification
cargo check✅ (Cargo.lock now pulls windows-native + secret-service backends)npx tsc --noEmit✅Part of the v1.6 alerts/UX polish batch.