Skip to content

thanos_sidecar: remove the network table row#1025

Draft
ideaship wants to merge 1 commit into
mainfrom
retire-thanos-sidecar
Draft

thanos_sidecar: remove the network table row#1025
ideaship wants to merge 1 commit into
mainfrom
retire-thanos-sidecar

Conversation

@ideaship

@ideaship ideaship commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What

Removes the thanos_sidecar_network row from docs/appendix/networks.md. The freed 172.31.101.192/28 block is left as a gap (the remaining rows are fixed allocations, not renumbered).

Why

Retire the thanos_sidecar role/service entirely (osism/issues#1402): its image
quay.io/thanos/thanos is frozen at v0.32.5 (unchanged since 2023-12-18) and its
role-default # renovate: annotation is inert (the file is not in the collection's
renovate.json fileMatch), so it cannot be maintained — drop it rather than wire it
into release-managed pinning.

Coordinated set — must land together

Four PRs for osism/issues#1402; deleting the role while its deploy playbook survives
would break the playbook, so they merge as a set:

⚠️ Deploy-behaviour change

thanos_sidecar is enabled by default (enable_thanos_sidecar | default('true')) and
deploys to the prometheus group, so merging this set stops deploying the Thanos
sidecar on the next run
. Please confirm this is acceptable for existing deployments.

Remove the thanos_sidecar_network row from docs/appendix/networks.md as
part of retiring the thanos_sidecar role/service entirely
(osism/issues#1402).

The role, its deploy playbook, and its inventory group are removed in the
companion changes; the documented network allocation no longer applies.
The freed 172.31.101.192/28 block is left as a gap rather than renumbering
the remaining rows, which are fixed allocations.

Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Roger Luethi <luethi@osism.tech>
@github-actions

Copy link
Copy Markdown

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 5 0 0 0.09s
✅ JSON jsonlint 4 0 0 0.12s
✅ JSON prettier 4 0 0 0.45s
✅ JSON v8r 4 0 0 7.88s
✅ MARKDOWN markdownlint 156 0 0 2.35s
✅ MARKDOWN markdown-table-formatter 156 0 0 0.47s
✅ REPOSITORY betterleaks yes no no 0.8s
✅ REPOSITORY checkov yes no no 19.25s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 1.69s
✅ REPOSITORY trufflehog yes no no 4.51s
✅ SPELL codespell 166 0 0 0.61s
⚠️ SPELL lychee 166 3 0 14.0s
✅ YAML prettier 6 0 0 0.46s
✅ YAML v8r 6 0 0 6.56s
✅ YAML yamllint 6 0 0 0.53s

Detailed Issues

⚠️ SPELL / lychee - 3 errors
📝 Summary
---------------------
🔍 Total..........879
🔗 Unique.........719
✅ Successful.....814
⏳ Timeouts.........1
🔀 Redirected......48
👻 Excluded........61
❓ Unknown..........0
🚫 Errors...........3
⛔ Unsupported......3

Errors in docs/guides/configuration-guide/openstack/index.md
[404] https://github.com/openstack/kolla/blob/master/docker/base/set_configs.py (at 370:30) | Rejected status code: 404 Not Found
[404] https://github.com/openstack/kolla/blob/master/docker/base/start.sh (at 369:37) | Rejected status code: 404 Not Found

Errors in docs/guides/developer-guide/style-guide.md
[TIMEOUT] https://wiki.openstack.org/wiki/GitCommitMessages (at 79:1) | Request timed out

Errors in docs/release-notes/index.md
[ERROR] https://release.osism.tech/ (at 11:1) | Connection failed. Check network connectivity and firewall settings

Hint: Followed 48 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,SPELL_CODESPELL,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants