thanos_sidecar: remove the inventory group#607
Draft
ideaship wants to merge 1 commit into
Draft
Conversation
Remove the [thanos_sidecar:children] group (children: prometheus) from inventory/50-monitoring as part of retiring the thanos_sidecar role/service entirely (osism/issues#1402). The role is dropped from osism/ansible-collection-services and its deploy playbook from osism/ansible-playbooks; with no consumer left, the inventory group serves nothing. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
[thanos_sidecar:children]inventory group frominventory/50-monitoring— with the role and playbook gone it has no consumer.Why
Retire the thanos_sidecar role/service entirely (osism/issues#1402): its image
quay.io/thanos/thanosis frozen atv0.32.5(unchanged since 2023-12-18) and itsrole-default
# renovate:annotation is inert (the file is not in the collection'srenovate.jsonfileMatch), so it cannot be maintained — drop it rather than wire itinto release-managed pinning.
Coordinated set — must land together
Four PRs for osism/issues#1402; deleting the role while its deploy playbook survives
would break the playbook, so they merge as a set:
.zuul.yamljob)thanos_sidecar is enabled by default (
enable_thanos_sidecar | default('true')) anddeploys to the
prometheusgroup, so merging this set stops deploying the Thanossidecar on the next run. Please confirm this is acceptable for existing deployments.