Add hw_firmware_type and hw_machine_type to meta schema#1242
Merged
Conversation
Both keys were missing from the meta schema in etc/schema.yaml, so
using them in an image definition failed validation with
"Unexpected element".
- hw_firmware_type: enum('uefi', None) — required e.g. for images that
must boot via UEFI (incorporates the change from #1233).
- hw_machine_type: enum('pc', 'q35', 'virt', None) — needed alongside
hw_firmware_type (e.g. q35).
Closes #1097
Closes #1236
Assisted-by: Claude:claude-opus-4-8
Co-authored-by: Johannes Kastl <git@johannes-kastl.de>
Signed-off-by: Christian Berendt <berendt@osism.tech>
berendt
force-pushed
the
add-hw-firmware-and-machine-type-to-schema
branch
from
5865058 to
cc05c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two missing keys to the
metaschema inetc/schema.yaml. Using either of them in an image definition previously failed validation withUnexpected element.hw_firmware_type: enum('uefi', None)— required e.g. for images that must boot via UEFI. Incorporates the change from etc/schema.yaml: add hw_firmware_type #1233.hw_machine_type: enum('pc', 'q35', 'virt', None)— needed alongsidehw_firmware_type(e.g.q35).Both keys are optional (
required=False).Validated with yamale: the new values are accepted, invalid values (e.g.
hw_firmware_type: bios,hw_machine_type: bogus) are rejected, and all existingetc/images/*.ymldefinitions still validate.Fixes #1097
Closes #1236
This supersedes #1233 (combined here with the
hw_machine_typeaddition); the originalhw_firmware_typechange is credited to @johanneskastl viaCo-authored-by.🤖 Generated with Claude Code