etc/schema.yaml: add hw_firmware_type#1233
Closed
johanneskastl wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Johannes Kastl <git@johannes-kastl.de>
Member
|
Thanks @johanneskastl! The |
berendt
added a commit
that referenced
this pull request
Jun 27, 2026
Both keys were missing from the meta schema in etc/schema.yaml, so
using them in an image definition failed validation with
"Unexpected element".
- hw_firmware_type: enum('uefi', None) — required e.g. for images that
must boot via UEFI (incorporates the change from #1233).
- hw_machine_type: enum('pc', 'q35', 'virt', None) — needed alongside
hw_firmware_type (e.g. q35).
Closes #1097
Closes #1236
Assisted-by: Claude:claude-opus-4-8
Co-authored-by: Johannes Kastl <git@johannes-kastl.de>
Signed-off-by: Christian Berendt <berendt@osism.tech>
berendt
added a commit
that referenced
this pull request
Jun 27, 2026
Both keys were missing from the meta schema in etc/schema.yaml, so
using them in an image definition failed validation with
"Unexpected element".
- hw_firmware_type: enum('uefi', None) — required e.g. for images that
must boot via UEFI (incorporates the change from #1233).
- hw_machine_type: enum('pc', 'q35', 'virt', None) — needed alongside
hw_firmware_type (e.g. q35).
Closes #1097
Closes #1236
Assisted-by: Claude:claude-opus-4-8
Co-authored-by: Johannes Kastl <git@johannes-kastl.de>
Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1097
Not sure if there is anything else that needs to be added (I have not looked into tests yet).
I found no other value for this, it seems to be either set to
uefior left out.