Skip to content

Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800] #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Apr 13, 2026
Merged

Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800] #3200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea7033
Add ROSA engineers as approvers for nightly job YAML files
christophermancini Apr 1, 2026
d46f54a
fix: remove unnecessary filter
christophermancini Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,19 @@ approvers:
- yiqinzhang
- varunraokadaparthi
- christophermancini

filters:
# Nightly job YAML files in openshift/release repo - ROSA engineers can approve
# Pattern: openshift-osde2e-main__nightly-*.yaml
# These files don't exist in osde2e repo, so this filter has no effect here
# Other files (openshift-osde2e-main.yaml, .config.prowgen, OWNERS) fall back to top-level approvers
"^openshift-osde2e-main__nightly-.*\\.yaml$":
approvers:
Copy link
Copy Markdown
Contributor

@ritmun ritmun Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this apply to osde2e repo? or just the release repo?

Copy link
Copy Markdown
Contributor Author

@christophermancini christophermancini Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritmun updated to be explicit path filtering for release repo only

- bmeng
- dustman9000
- smarthall
- ravitri
- ritmun
- yiqinzhang
- varunraokadaparthi
- christophermancini