Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800]#3200
Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800]#3200christophermancini wants to merge 1 commit intoopenshift:mainfrom
Conversation
Add file-specific ownership filters to allow ROSA engineers (bmeng, dustman9000, smarthall, ravitri) to approve changes to nightly job configuration files while keeping openshift-osde2e-main.yaml and config.prowgen restricted to core team. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christophermancini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add ROSA engineers as approvers for nightly job YAML files
What
Add file-specific ownership filters to allow ROSA engineers (bmeng, dustman9000, smarthall, ravitri) to approve nightly job YAML files, while keeping
openshift-osde2e-main.yamlandconfig.prowgenrestricted to the core team.Why
ROSA engineers need to maintain nightly job configurations in the openshift/release repo, but the two core config files should remain under core team control only.
How
Uses Prow's
filtersfeature to define different approvers based on file patterns. The OWNERS file auto-syncs toopenshift/release/ci-operator/config/openshift/osde2e/.References