Skip to content

Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800]#3200

Open
christophermancini wants to merge 1 commit intoopenshift:mainfrom
christophermancini:cm/owners
Open

Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800]#3200
christophermancini wants to merge 1 commit intoopenshift:mainfrom
christophermancini:cm/owners

Conversation

@christophermancini
Copy link
Copy Markdown
Contributor

Add ROSA engineers as approvers for nightly job YAML files

What

Add file-specific ownership filters to allow ROSA engineers (bmeng, dustman9000, smarthall, ravitri) to approve nightly job YAML files, while keeping openshift-osde2e-main.yaml and config.prowgen restricted to the core team.

Why

ROSA engineers need to maintain nightly job configurations in the openshift/release repo, but the two core config files should remain under core team control only.

How

Uses Prow's filters feature to define different approvers based on file patterns. The OWNERS file auto-syncs to openshift/release/ci-operator/config/openshift/osde2e/.

References

Add file-specific ownership filters to allow ROSA engineers (bmeng, dustman9000,
smarthall, ravitri) to approve changes to nightly job configuration files while
keeping openshift-osde2e-main.yaml and config.prowgen restricted to core team.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 88289084-b424-4822-956e-2f0552a115bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from YiqinZhang and minlei98 April 1, 2026 20:51
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophermancini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@christophermancini christophermancini changed the title Add ROSA engineers as approvers for nightly job YAML files Add ROSA engineers as approvers for nightly job YAML files [SDCICD-1800] Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants