AGENTS.md: Add notes on plugin SDK, git workflow and release branches#2103
AGENTS.md: Add notes on plugin SDK, git workflow and release branches#2103kyoto wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthrough
ChangesDocumentation updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
AGENTS.md (1)
161-180:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winParameterize the PR base branch.
Now that the workflow docs list
main,release-4.19, andpattern-fly-5, this example should not hardcodemain; otherwise release-line work will be opened against the wrong base.Based on learnings: Never merge or commit directly to
main,release-4.19, orpattern-fly-5— all changes must go through pull requests using a fork-based workflow.Suggested edit
-2. **Create the PR** against `origin/main` using your fork's branch: +2. **Create the PR** against the branch you're updating using your fork's branch: @@ - gh pr create --repo openshift/lightspeed-console --head <your-github-user>:<branch> --base main + gh pr create --repo openshift/lightspeed-console --head <your-github-user>:<branch> --base <target-branch> @@ -4. **Create the PR** against `origin/main` using `--head <user>:<branch>` +4. **Create the PR** against the target branch using `--head <user>:<branch>`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` around lines 161 - 180, The Pull Requests section hardcodes `main` as the base branch in the gh pr create command and in the Branch Completion section, but the workflow documentation states that changes should go against different protected branches (main, release-4.19, or pattern-fly-5) depending on the work. Replace the hardcoded `main` in both the gh pr create command (in the `--base` flag) and in the "Create the PR against `origin/main`" instruction in the Branch Completion section with a parameterized placeholder like `<base-branch>` so that developers can specify the correct target branch for their work, whether it's main, release-4.19, or pattern-fly-5. This ensures the documentation guidance aligns with the multi-branch workflow.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 30-36: Update the Plugin SDK docs section to use an actually
supported branch name instead of the stale example. Replace the reference to
`release-4.17` in the parenthetical instruction about swapping branch names with
either a generic placeholder or use one of the repo's documented supported
branches like `release-4.19`. This ensures the documentation example accurately
reflects available branches in the openshift/console repository.
---
Outside diff comments:
In `@AGENTS.md`:
- Around line 161-180: The Pull Requests section hardcodes `main` as the base
branch in the gh pr create command and in the Branch Completion section, but the
workflow documentation states that changes should go against different protected
branches (main, release-4.19, or pattern-fly-5) depending on the work. Replace
the hardcoded `main` in both the gh pr create command (in the `--base` flag) and
in the "Create the PR against `origin/main`" instruction in the Branch
Completion section with a parameterized placeholder like `<base-branch>` so that
developers can specify the correct target branch for their work, whether it's
main, release-4.19, or pattern-fly-5. This ensures the documentation guidance
aligns with the multi-branch workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9985b00f-4d4a-4739-8ea0-8516d6de2cb2
📒 Files selected for processing (2)
AGENTS.mdREADME.md
0015fc1 to
13816e3
Compare
|
New changes are detected. LGTM label has been removed. |
|
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console" |
|
/cherry-pick release-4.19 |
|
@kyoto: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kyoto: Overrode contexts on behalf of kyoto: Red Hat Konflux / e2e-console-pf6 / lightspeed-console DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary by CodeRabbit