fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1 #127
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| module github.com/openshift/lightspeed-agentic-operator | ||
|
|
||
| go 1.26.0 | ||
|
|
||
| require ( | ||
| github.com/openshift/api v0.0.0-20260618083218-a3c8dea7f8bc | ||
| github.com/spf13/cobra v1.10.2 | ||
| k8s.io/api v0.36.0 | ||
| k8s.io/apiextensions-apiserver v0.36.0 | ||
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/cli-runtime v0.35.3 | ||
| k8s.io/client-go v0.36.0 | ||
| k8s.io/utils v0.0.0-20260507154919-ff6756f316d2 | ||
| sigs.k8s.io/controller-runtime v0.24.1 | ||
|
Comment on lines
+8
to
+14
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n --glob '!**/vendor/**' 'k8s\.io/cli-runtime|k8s\.io/(api|apimachinery|client-go|apiextensions-apiserver)' .Repository: openshift/lightspeed-agentic-operator Length of output: 18124 🏁 Script executed: #!/bin/bash
# Check for any comments or context around cli-runtime version in go.mod
head -20 go.modRepository: openshift/lightspeed-agentic-operator Length of output: 623 🏁 Script executed: #!/bin/bash
# Check git history for this specific line
git log -p --all -S 'k8s.io/cli-runtime v0.35.3' -- go.mod | head -100Repository: openshift/lightspeed-agentic-operator Length of output: 4590 🏁 Script executed: #!/bin/bash
# Check if 0.36.0 of cli-runtime is available
rg -A 2 -B 2 'cli-runtime' go.sumRepository: openshift/lightspeed-agentic-operator Length of output: 550 🌐 Web query:
💡 Result: The k8s.io/cli-runtime module version v0.36.0 was released on April 22, 2026 [1]. This release occurred in conjunction with the broader Kubernetes v1.36.0 release, which followed a development cycle that began on January 12, 2026 [2][3]. Key details regarding this release: - Release Context: The v0.36.0 version serves as a staging repository dependency for Kubernetes, used to facilitate the creation of kubectl commands and plugins [4]. It is synced from the main Kubernetes repository [4]. - Release History: Following the initial v0.36.0 release in April, the module has seen further updates, including the release of v0.36.1 on May 12, 2026 [5][6]. - Development Milestones: The v0.36.0 release was preceded by several prerelease versions, such as v0.36.0-alpha.0 (March 19, 2026), v0.36.0-beta.0 (March 20, 2026), and v0.36.0-rc.0 (April 9, 2026) [7][8][1]. As of today, June 16, 2026, v0.36.0 is no longer the latest version of the k8s.io/cli-runtime module [5][6]. Citations:
🏁 Script executed: #!/bin/bash
# Check if there's any build or test failure tracking related to cli-runtime
git log --oneline --all | head -30Repository: openshift/lightspeed-agentic-operator Length of output: 2382 🏁 Script executed: #!/bin/bash
# Look for any GitHub issues or PR comments mentioning cli-runtime version compatibility
rg -i 'cli-runtime.*0\.36|cli-runtime.*version|version.*cli-runtime' . --type-list | head -20Repository: openshift/lightspeed-agentic-operator Length of output: 471 🏁 Script executed: #!/bin/bash
# Check what genericclioptions APIs are actually used from cli-runtime
rg 'genericclioptions\.' --type go | head -20Repository: openshift/lightspeed-agentic-operator Length of output: 1582 🌐 Web query:
💡 Result: The controller-runtime v0.24.1 release, introduced in April 2026, includes several breaking changes primarily driven by the update to Kubernetes v1.36 dependencies [1][2]. Key breaking changes in the v0.24.x release cycle include: Builder and Webhooks: The deprecated custom path function for webhooks has been removed [2][3]. Scheme: The scheme builder has been officially deprecated [2][3]. Dependencies: The library has updated its core dependencies to k8s.io/* v1.36 [1][2]. Generic Validator and Defaulter: A new generic mechanism for webhooks was introduced, allowing for more flexible implementations [1]. Regarding compatibility with cli-runtime, controller-runtime maintains its versioning strategy by aligning its minor versions with specific Kubernetes minor releases [4][5]. It does not provide a formal compatibility matrix with other external libraries or cli-runtime versions beyond the Kubernetes dependencies defined in its go.mod file [4][5][6]. Because controller-runtime and its related Kubernetes libraries (like client-go and apimachinery) frequently undergo breaking changes in their minor versions, compatibility is typically only guaranteed within the versions explicitly tested and scaffolded for a specific release [4][6]. If you are upgrading to v0.24.1, it is recommended to review your go.mod file to ensure alignment with the k8s.io/* v1.36 dependencies and verify that your custom webhook implementations and scheme management align with the updated patterns [2][3][4]. Citations:
Bump The other k8s modules (api, apimachinery, client-go, apiextensions-apiserver) are all at v0.36.0, but 🤖 Prompt for AI Agents |
||
| sigs.k8s.io/yaml v1.6.0 | ||
| ) | ||
|
|
||
|
|
@@ -28,8 +28,6 @@ require ( | |
| github.com/go-openapi/swag/stringutils v0.26.1 // indirect | ||
| github.com/go-openapi/swag/typeutils v0.26.1 // indirect | ||
| github.com/go-openapi/swag/yamlutils v0.26.1 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 146
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 91
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 63
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 127
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 253
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 184
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 1018
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 63
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 723
🏁 Script executed:
Repository: openshift/lightspeed-agentic-operator
Length of output: 63
Bump
test/agent/Dockerfileto match Go 1.26.0 requirement.Both
go.modandapi/go.modrequire Go 1.26.0, buttest/agent/Dockerfilestill usesgolang:1.25.7-bookworm. Thego mod downloadandgo buildsteps will fail because the toolchain version is below the minimum required in thego.modfiles. The Dockerfile's own comment states "Builder image tracks go.mod; bump if toolchain rejects the tag"—this needs to be addressed by updating the base image togolang:1.26.0-bookworm.🤖 Prompt for AI Agents