fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1#127
fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1#127red-hat-konflux[bot] wants to merge 1 commit into
Conversation
red-hat-konflux
Bot
added
approved
ℹ️ Artifact update noticeFile name: api/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughGo toolchain version bumped from 1.25.7 to 1.26.0 in both ChangesGo Toolchain and Kubernetes Dependency Updates
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/go.mod`:
- Around line 3-8: The test/agent/Dockerfile uses an outdated Go base image
version (golang:1.25.7-bookworm) that does not meet the Go 1.26.0 requirement
specified in both go.mod and api/go.mod files. Update the Dockerfile's base
image specification to use golang:1.26.0-bookworm instead of
golang:1.25.7-bookworm to ensure the go mod download and go build steps can
execute successfully with the required toolchain version.
In `@go.mod`:
- Around line 8-14: Update the k8s.io/cli-runtime dependency version from
v0.35.3 to v0.36.0 in the go.mod file to align with the other Kubernetes stack
dependencies (k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/apimachinery,
and k8s.io/client-go) which are all pinned to v0.36.0. Change the version
specification on the k8s.io/cli-runtime line from v0.35.3 to v0.36.0 to
eliminate the version mismatch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9f40a918-1999-4795-afa7-2d49c3d495bf
⛔ Files ignored due to path filters (2)
api/go.sumis excluded by!**/*.sum,!api/go.sumgo.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (2)
api/go.modgo.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
| go 1.26.0 | ||
|
|
||
| require ( | ||
| k8s.io/apiextensions-apiserver v0.35.3 | ||
| k8s.io/apimachinery v0.35.3 | ||
| sigs.k8s.io/controller-runtime v0.23.3 | ||
| k8s.io/apiextensions-apiserver v0.36.0 | ||
| k8s.io/apimachinery v0.36.0 | ||
| sigs.k8s.io/controller-runtime v0.24.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n --glob '!**/vendor/**' '\bgo 1\.25\.7\b|\bgolang:1\.25\b|\bgolang:1\.26\b|Go 1\.25|Go 1\.26' .Repository: openshift/lightspeed-agentic-operator
Length of output: 146
🏁 Script executed:
#!/bin/bash
# Check root go.mod version requirement
head -20 go.mod | grep '^go 'Repository: openshift/lightspeed-agentic-operator
Length of output: 91
🏁 Script executed:
#!/bin/bash
# Find CI workflow files
fd -e yml -e yaml 'workflows|\.github' && cat .github/workflows/*.yml 2>/dev/null | rg -i 'go-version|golang|1\.25|1\.26' || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 63
🏁 Script executed:
#!/bin/bash
# Check all references to Go versions across the repo
rg -n 'go 1\.(25|26)' --glob '!vendor' .Repository: openshift/lightspeed-agentic-operator
Length of output: 127
🏁 Script executed:
#!/bin/bash
# Check for CI configuration in other common locations
find . -maxdepth 2 -type f \( -name '*.yml' -o -name '*.yaml' -o -name 'Makefile' -o -name '.gitlab-ci.yml' \) | head -20Repository: openshift/lightspeed-agentic-operator
Length of output: 253
🏁 Script executed:
#!/bin/bash
# Check how test/agent/Dockerfile is used and what it builds
rg -n 'test/agent/Dockerfile|Dockerfile.*test.*agent' . --glob '!vendor'Repository: openshift/lightspeed-agentic-operator
Length of output: 184
🏁 Script executed:
#!/bin/bash
# Look at test/agent/Dockerfile context
head -30 ./test/agent/DockerfileRepository: openshift/lightspeed-agentic-operator
Length of output: 1018
🏁 Script executed:
#!/bin/bash
# Check Tekton pipelines for Go version references
cat ./.tekton/lightspeed-agentic-operator-pull-request.yaml ./.tekton/lightspeed-agentic-operator-push.yaml 2>/dev/null | rg -i 'golang|go-version|1\.25|1\.26' -B2 -A2 || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 63
🏁 Script executed:
#!/bin/bash
# Check Makefile for any Go version pins
cat ./Makefile | rg -n 'golang|go-version|1\.25|1\.26' || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 723
🏁 Script executed:
#!/bin/bash
# Check README or docs for Go version documentation
find . -maxdepth 2 -name 'README*' -o -name '*.md' | xargs grep -l 'Go 1\.[0-9]' 2>/dev/null || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 63
Bump test/agent/Dockerfile to match Go 1.26.0 requirement.
Both go.mod and api/go.mod require Go 1.26.0, but test/agent/Dockerfile still uses golang:1.25.7-bookworm. The go mod download and go build steps will fail because the toolchain version is below the minimum required in the go.mod files. The Dockerfile's own comment states "Builder image tracks go.mod; bump if toolchain rejects the tag"—this needs to be addressed by updating the base image to golang:1.26.0-bookworm.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api/go.mod` around lines 3 - 8, The test/agent/Dockerfile uses an outdated Go
base image version (golang:1.25.7-bookworm) that does not meet the Go 1.26.0
requirement specified in both go.mod and api/go.mod files. Update the
Dockerfile's base image specification to use golang:1.26.0-bookworm instead of
golang:1.25.7-bookworm to ensure the go mod download and go build steps can
execute successfully with the required toolchain version.
| k8s.io/api v0.36.0 | ||
| k8s.io/apiextensions-apiserver v0.36.0 | ||
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/cli-runtime v0.35.3 | ||
| k8s.io/client-go v0.35.3 | ||
| k8s.io/client-go v0.36.0 | ||
| k8s.io/utils v0.0.0-20260507154919-ff6756f316d2 | ||
| sigs.k8s.io/controller-runtime v0.23.3 | ||
| sigs.k8s.io/controller-runtime v0.24.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n --glob '!**/vendor/**' 'k8s\.io/cli-runtime|k8s\.io/(api|apimachinery|client-go|apiextensions-apiserver)' .Repository: openshift/lightspeed-agentic-operator
Length of output: 18124
🏁 Script executed:
#!/bin/bash
# Check for any comments or context around cli-runtime version in go.mod
head -20 go.modRepository: openshift/lightspeed-agentic-operator
Length of output: 623
🏁 Script executed:
#!/bin/bash
# Check git history for this specific line
git log -p --all -S 'k8s.io/cli-runtime v0.35.3' -- go.mod | head -100Repository: openshift/lightspeed-agentic-operator
Length of output: 4590
🏁 Script executed:
#!/bin/bash
# Check if 0.36.0 of cli-runtime is available
rg -A 2 -B 2 'cli-runtime' go.sumRepository: openshift/lightspeed-agentic-operator
Length of output: 550
🌐 Web query:
kubernetes k8s.io cli-runtime v0.36.0 release
💡 Result:
The k8s.io/cli-runtime module version v0.36.0 was released on April 22, 2026 [1]. This release occurred in conjunction with the broader Kubernetes v1.36.0 release, which followed a development cycle that began on January 12, 2026 [2][3]. Key details regarding this release: - Release Context: The v0.36.0 version serves as a staging repository dependency for Kubernetes, used to facilitate the creation of kubectl commands and plugins [4]. It is synced from the main Kubernetes repository [4]. - Release History: Following the initial v0.36.0 release in April, the module has seen further updates, including the release of v0.36.1 on May 12, 2026 [5][6]. - Development Milestones: The v0.36.0 release was preceded by several prerelease versions, such as v0.36.0-alpha.0 (March 19, 2026), v0.36.0-beta.0 (March 20, 2026), and v0.36.0-rc.0 (April 9, 2026) [7][8][1]. As of today, June 16, 2026, v0.36.0 is no longer the latest version of the k8s.io/cli-runtime module [5][6].
Citations:
- 1: https://pkg.go.dev/k8s.io/cli-runtime@v0.35.2
- 2: https://github.com/kubernetes/sig-release/blob/c6536319e0018fc66265ea72f440560d314c5370/releases/release-1.36/README.md
- 3: https://groups.google.com/g/kubernetes-sig-release/c/73ZKJ3lbQBw
- 4: https://github.com/kubernetes/cli-runtime/
- 5: https://pkg.go.dev/k8s.io/cli-runtime
- 6: https://pkg.go.dev/k8s.io/cli-runtime/pkg
- 7: https://pkg.go.dev/k8s.io/cli-runtime@v0.36.0-alpha.0
- 8: https://pkg.go.dev/k8s.io/kubectl@v0.36.0
🏁 Script executed:
#!/bin/bash
# Check if there's any build or test failure tracking related to cli-runtime
git log --oneline --all | head -30Repository: openshift/lightspeed-agentic-operator
Length of output: 2382
🏁 Script executed:
#!/bin/bash
# Look for any GitHub issues or PR comments mentioning cli-runtime version compatibility
rg -i 'cli-runtime.*0\.36|cli-runtime.*version|version.*cli-runtime' . --type-list | head -20Repository: openshift/lightspeed-agentic-operator
Length of output: 471
🏁 Script executed:
#!/bin/bash
# Check what genericclioptions APIs are actually used from cli-runtime
rg 'genericclioptions\.' --type go | head -20Repository: openshift/lightspeed-agentic-operator
Length of output: 1582
🌐 Web query:
controller-runtime v0.24.1 cli-runtime compatibility breaking changes
💡 Result:
The controller-runtime v0.24.1 release, introduced in April 2026, includes several breaking changes primarily driven by the update to Kubernetes v1.36 dependencies [1][2]. Key breaking changes in the v0.24.x release cycle include: Builder and Webhooks: The deprecated custom path function for webhooks has been removed [2][3]. Scheme: The scheme builder has been officially deprecated [2][3]. Dependencies: The library has updated its core dependencies to k8s.io/* v1.36 [1][2]. Generic Validator and Defaulter: A new generic mechanism for webhooks was introduced, allowing for more flexible implementations [1]. Regarding compatibility with cli-runtime, controller-runtime maintains its versioning strategy by aligning its minor versions with specific Kubernetes minor releases [4][5]. It does not provide a formal compatibility matrix with other external libraries or cli-runtime versions beyond the Kubernetes dependencies defined in its go.mod file [4][5][6]. Because controller-runtime and its related Kubernetes libraries (like client-go and apimachinery) frequently undergo breaking changes in their minor versions, compatibility is typically only guaranteed within the versions explicitly tested and scaffolded for a specific release [4][6]. If you are upgrading to v0.24.1, it is recommended to review your go.mod file to ensure alignment with the k8s.io/* v1.36 dependencies and verify that your custom webhook implementations and scheme management align with the updated patterns [2][3][4].
Citations:
- 1: https://github.com/kubernetes-sigs/controller-runtime/releases
- 2: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.24.0
- 3: Bump sigs.k8s.io/controller-runtime from 0.23.3 to 0.24.1 qdrant/kubernetes-api#274
- 4: https://github.com/kubernetes-sigs/controller-runtime/blob/main/VERSIONING.md
- 5: https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.24.0
- 6: https://book.kubebuilder.io/versions_compatibility_supportability
Bump k8s.io/cli-runtime to v0.36.0 to align with the rest of the Kubernetes stack.
The other k8s modules (api, apimachinery, client-go, apiextensions-apiserver) are all at v0.36.0, but k8s.io/cli-runtime remains pinned at v0.35.3. The v0.36.0 release exists (released April 22, 2026) and the CLI code uses only stable, widely-compatible APIs from cli-runtime (IOStreams, ConfigFlags). Keeping this version-skewed across the same minor release introduces unnecessary dependency mismatch risk, especially since controller-runtime v0.24.1 itself requires k8s 1.36 dependencies.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 8 - 14, Update the k8s.io/cli-runtime dependency version
from v0.35.3 to v0.36.0 in the go.mod file to align with the other Kubernetes
stack dependencies (k8s.io/api, k8s.io/apiextensions-apiserver,
k8s.io/apimachinery, and k8s.io/client-go) which are all pinned to v0.36.0.
Change the version specification on the k8s.io/cli-runtime line from v0.35.3 to
v0.36.0 to eliminate the version mismatch.
openshift-ci
Bot
added
the
needs-rebase
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
from
b8ad4a8 to
e6e371a
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci
Bot
removed
the
needs-rebase
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
3 times, most recently
from
991f618 to
ec145a9
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
from
ec145a9 to
048cd86
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v0.23.3→v0.24.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.24.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.24.0...v0.24.1
v0.24.0Compare Source
🐛 Bug Fixes
🌱 Others
StartLoggingfor event debug logs (#3451)🌱 CI & linters
tools/setup-envtestsubmodule (#3476)📖 Additionally, there has been 1 contribution to our documentation. (#3477)
Dependencies
Added
Changed
8a7402a→944ab1f078029d→bd525daa0af3ef→8636f87200df99→8636f87f2248ac589584f→43fb72cbc988d5→b8788abRemoved
9bdfabeThanks to all our contributors! 😊
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.