Skip to content

[4.18] OCPBUGS-78037: add instantAccessDurationMinutes parameter to enable IA snapshots for PremiumV2/UltraSSD disks#130

Open
RomanBednar wants to merge 4 commits into
openshift:release-4.18from
RomanBednar:instant-access-4.18
Open

[4.18] OCPBUGS-78037: add instantAccessDurationMinutes parameter to enable IA snapshots for PremiumV2/UltraSSD disks#130
RomanBednar wants to merge 4 commits into
openshift:release-4.18from
RomanBednar:instant-access-4.18

Conversation

@RomanBednar
Copy link
Copy Markdown

@RomanBednar RomanBednar commented Mar 26, 2026 •
edited
Loading

This is a manual cherry-pick of: #128 (see the PR description for more details)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2be6771c-879e-4c20-9fd0-14525143279e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 26, 2026

@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78035 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link
Copy Markdown
Author

RomanBednar commented Mar 26, 2026

/hold

go.mod has replace directives towards my personal fork of cloud-provider-azure so we can test this PR easily. After we merge the cloud-provider-azure changes we'll update the replace here and can continue with merging this PR.

@openshift-ci openshift-ci Bot requested review from bertinatto and gnufied March 26, 2026 13:27
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2026
@RomanBednar RomanBednar force-pushed the instant-access-4.18 branch 4 times, most recently from 8df93d1 to 3532740 Compare March 31, 2026 12:57
@RomanBednar
Copy link
Copy Markdown
Author

RomanBednar commented Mar 31, 2026

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78035 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This is a manual cherry-pick of: #128 (see the PR description for more details)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@radeore radeore mentioned this pull request Apr 15, 2026
Open
RomanBednar and others added 4 commits May 7, 2026 13:39
@RomanBednar @claude
UPSTREAM: <carry>: Update armcompute dependency from v6 to v7
53837a4 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RomanBednar @claude
UPSTREAM: 3141: perf: use ready to use to wait for snapshot as defaul…
b553779 
…t method

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RomanBednar @claude
UPSTREAM: 3507: feat: add instantAccessDurationMinutes parameter to e…
623a6f8 
…nable IA snapshots for PremiumV2/UltraSSD disks

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RomanBednar @claude
UPSTREAM: <carry>: update V2 driver code and fix unit tests
09678c4 
- match Driver V1 behaviour in V2 Driver code - V2 was removed upstream
  and backported, however we still have it in OpenShift
- adapts the receiver from fakeDriver to fakeDriverV1 so that
  fakeDriverV1 satisfies the FakeDriver interface
- move useDriverV2 flag declaration to azuredisk.go (from azuredisk_v2.go)
  so it is available in both V1 and V2 builds for test skipping
- set shouldWaitForSnapshotReady = true in the fakeDriverV2 constructor
  to match fakeDriverV1 behavior
- skip cross-region snapshot tests for v2 since DriverV2 does not
  implement cross-region snapshot support

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RomanBednar RomanBednar force-pushed the instant-access-4.18 branch from 3532740 to 09678c4 Compare May 7, 2026 11:39
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-csi 09678c4 link true /test e2e-azure-csi
ci/prow/images 09678c4 link true /test images
ci/prow/unit 09678c4 link true /test unit
ci/prow/verify-deps 09678c4 link true /test verify-deps
ci/prow/e2e-azure 09678c4 link true /test e2e-azure
ci/prow/e2e-azure-ovn-upgrade 09678c4 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@gnufied gnufied Awaiting requested review from gnufied

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RomanBednar @openshift-ci-robot