Skip to content

[4.18] OCPBUGS-78037: bump Azure SDK armcompute to v7.0.0#160

Open
RomanBednar wants to merge 1 commit into
openshift:release-4.18-azure-disk-csi-driverfrom
RomanBednar:release-4.18-azure-disk-csi-driver
Open

[4.18] OCPBUGS-78037: bump Azure SDK armcompute to v7.0.0#160
RomanBednar wants to merge 1 commit into
openshift:release-4.18-azure-disk-csi-driverfrom
RomanBednar:release-4.18-azure-disk-csi-driver

Conversation

@RomanBednar
Copy link
Copy Markdown

In order to be able to use instantAccessDurationMinutes in Azure Disk CSI Driver we need to bump Azure SDK to v7 first where this parmeter was added. However, we need to get this parameter into 4.18 which is limited by golang version 1.23. This is the reason we bump here to v7.0.0 which is not the most recent one, but it is the only version that enables instant access snapshot feature and does not require golang 1.24 or higher.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@RomanBednar: This pull request references Jira Issue OCPBUGS-77492, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-77492 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In order to be able to use instantAccessDurationMinutes in Azure Disk CSI Driver we need to bump Azure SDK to v7 first where this parmeter was added. However, we need to get this parameter into 4.18 which is limited by golang version 1.23. This is the reason we bump here to v7.0.0 which is not the most recent one, but it is the only version that enables instant access snapshot feature and does not require golang 1.24 or higher.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01e925bf-1bf2-4f86-801e-9c4da1d40351

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from nrb and sub-mod March 4, 2026 14:22
@RomanBednar RomanBednar force-pushed the release-4.18-azure-disk-csi-driver branch from c7cc157 to 50397d9 Compare March 4, 2026 14:24
@RomanBednar RomanBednar changed the title OCPBUGS-77492: bump Azure SDK to v7 OCPBUGS-77248: bump Azure SDK to v7 Mar 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. labels Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@RomanBednar: This pull request references Jira Issue OCPBUGS-77248, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-77248 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In order to be able to use instantAccessDurationMinutes in Azure Disk CSI Driver we need to bump Azure SDK to v7 first where this parmeter was added. However, we need to get this parameter into 4.18 which is limited by golang version 1.23. This is the reason we bump here to v7.0.0 which is not the most recent one, but it is the only version that enables instant access snapshot feature and does not require golang 1.24 or higher.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar RomanBednar force-pushed the release-4.18-azure-disk-csi-driver branch from 50397d9 to 07c145a Compare March 4, 2026 14:53
@RomanBednar RomanBednar changed the title OCPBUGS-77248: bump Azure SDK to v7 OCPBUGS-78037: bump Azure SDK to v7 Mar 10, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is invalid:

  • expected Jira Issue OCPBUGS-78037 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In order to be able to use instantAccessDurationMinutes in Azure Disk CSI Driver we need to bump Azure SDK to v7 first where this parmeter was added. However, we need to get this parameter into 4.18 which is limited by golang version 1.23. This is the reason we bump here to v7.0.0 which is not the most recent one, but it is the only version that enables instant access snapshot feature and does not require golang 1.24 or higher.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar RomanBednar changed the title OCPBUGS-78037: bump Azure SDK to v7 [4.18] OCPBUGS-78037: bump Azure SDK to v7 Mar 24, 2026
@RomanBednar RomanBednar changed the title [4.18] OCPBUGS-78037: bump Azure SDK to v7 [4.18] OCPBUGS-78037: bump Azure SDK armcompute to v7.0.0 Mar 24, 2026
@RomanBednar RomanBednar force-pushed the release-4.18-azure-disk-csi-driver branch 4 times, most recently from 9fbedab to c2f13f8 Compare March 31, 2026 10:19
Bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute
from v6 (v6.1.0) to v7 (v7.0.0) across all modules.

The published azclient versions with armcompute/v7 (v0.14.3+) require
go 1.25, which exceeds OpenShift's Go version constraints (go 1.22 for
4.18). Local replace directives for pkg/azclient submodules allow bumping
armcompute to v7.0.0 in the local source without requiring a new published
azclient version or a Go version bump.
@RomanBednar RomanBednar force-pushed the release-4.18-azure-disk-csi-driver branch from c2f13f8 to 4cabc02 Compare March 31, 2026 12:56
@knobunc
Copy link
Copy Markdown

knobunc commented Mar 31, 2026

/override ci/prow/images

This repo is just being used for a build dependency for the real image build elsewhere.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/images

Details

In response to this:

/override ci/prow/images

This repo is just being used for a build dependency for the real image build elsewhere.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knobunc
Copy link
Copy Markdown

knobunc commented Mar 31, 2026

/override ci/prow/security
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-azure-ovn

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-azure-ovn, ci/prow/e2e-azure-ovn-upgrade, ci/prow/security

Details

In response to this:

/override ci/prow/security
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-azure-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knobunc
Copy link
Copy Markdown

knobunc commented Mar 31, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 4cabc02 link true /test images
ci/prow/e2e-azure-ovn-upgrade 4cabc02 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn 4cabc02 link true /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knobunc
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@radeore
Copy link
Copy Markdown

radeore commented Apr 15, 2026

Verified this on OCP 4.18 build generated using azure-disk PR. New snapshot parameter instantAccessDurationMinutes is supported as expected and azure-disk storage regression test run is also successful.

@radeore
Copy link
Copy Markdown

radeore commented Apr 15, 2026

/verified by @radeore

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@radeore: This PR has been marked as verified by @radeore.

Details

In response to this:

/verified by @radeore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@RomanBednar
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 11, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-78035 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • bug has dependents

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from radeore May 11, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants