[4.18] OCPBUGS-78037: bump Azure SDK armcompute to v7.0.0#160
Conversation
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-77492, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
c7cc157 to
50397d9
Compare
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-77248, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
50397d9 to
07c145a
Compare
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9fbedab to
c2f13f8
Compare
Bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute from v6 (v6.1.0) to v7 (v7.0.0) across all modules. The published azclient versions with armcompute/v7 (v0.14.3+) require go 1.25, which exceeds OpenShift's Go version constraints (go 1.22 for 4.18). Local replace directives for pkg/azclient submodules allow bumping armcompute to v7.0.0 in the local source without requiring a new published azclient version or a Go version bump.
c2f13f8 to
4cabc02
Compare
|
/override ci/prow/images This repo is just being used for a build dependency for the real image build elsewhere. |
|
@knobunc: Overrode contexts on behalf of knobunc: ci/prow/images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/security |
|
@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-azure-ovn, ci/prow/e2e-azure-ovn-upgrade, ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knobunc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Verified this on OCP 4.18 build generated using azure-disk PR. New snapshot parameter instantAccessDurationMinutes is supported as expected and azure-disk storage regression test run is also successful. |
|
/verified by @radeore |
|
@radeore: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/jira refresh |
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-78037, which is valid. The bug has been moved to the POST state. 5 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
In order to be able to use
instantAccessDurationMinutesin Azure Disk CSI Driver we need to bump Azure SDK to v7 first where this parmeter was added. However, we need to get this parameter into 4.18 which is limited by golang version 1.23. This is the reason we bump here to v7.0.0 which is not the most recent one, but it is the only version that enables instant access snapshot feature and does not require golang 1.24 or higher.