Frontend base Migration by jesusbalderramawgu · Pull Request #210 · openedx/frontend-app-admin-console

jesusbalderramawgu · 2026-08-19T17:32:01Z

Description

PR to migrate this repository to frontend base. It closes this issue.
Turning the MFE into a library that runs inside the
frontend-base shell. Follows the official "Migrating an MFE to frontend-base" guide.

How I have tested this change?

Ran unit tests
Built the project
Ran the project locally and tested manually the different views

Screenshots

Closes #211

openedx-webhooks · 2026-08-19T17:32:07Z

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-08-25T22:07:49Z

Codecov Report

❌ Patch coverage is 98.47328% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.52%. Comparing base (36cc825) to head (758e7f6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/app.ts	0.00%	1 Missing ⚠️
src/providers.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   97.65%   98.52%   +0.86%     
==========================================
  Files          68       73       +5     
  Lines        1665     1288     -377     
  Branches      443      421      -22     
==========================================
- Hits         1626     1269     -357     
+ Misses         39       19      -20

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jesusbalderramawgu · 2026-08-25T22:10:19Z

I have updated the PR with the latest changes from frontend base.

I rebased this branch and noticed that codecov is complaining, I will check to cover the pending test coverage.
anything please let me know. Thank you!

arbrandes · 2026-09-02T12:32:14Z

+  {
+    id: 'org.openedx.frontend.route.adminConsole.main',
+    path: '/authz/*',
+    Component: Main,


The app no longer requires an authenticated user. Please add loader: authenticatedLoader to the route.

arbrandes · 2026-09-02T13:41:01Z

Also, please rebase on latest master so we don't lose any new features/fixes. I see a couple landed, recently.

jesusbalderramawgu · 2026-09-02T21:50:29Z

Thank you @arbrandes for your great feedback!
I have addressed your comments, anything please let me know!

arbrandes

Thanks! Next round!

arbrandes · 2026-09-03T17:41:48Z

-        </Button>
+          <Button
+            as={Hyperlink}
+            destination={`${getAppConfig(appId).COURSE_AUTHORING_MICROFRONTEND_URL}`}


Use destination={getUrlByRouteRole('org.openedx.frontend.role.courseAuthoring')}, drop the getAppConfig/appId imports, and remove the now-dead COURSE_AUTHORING_MICROFRONTEND_URL entry in site.config.test.tsx.

arbrandes · 2026-09-03T17:41:48Z

+  "exclude": [
+    "src/**/*.test.ts",
+    "src/**/*.test.tsx",
+    "src/**/*.spec.ts",
+    "src/**/*.spec.tsx",
+    "src/__mocks__/**/*",
+    "src/setupTest.tsx"
+  ]


Add "src/testUtils.tsx" here, and delete the stray file named tsconfig.build.json (with a trailing space) that the exclusion landed in instead.

arbrandes · 2026-09-03T17:41:48Z

+import { SiteContext } from '@openedx/frontend-base';
 import userEvent from '@testing-library/user-event';
 import { MemoryRouter, Route, Routes } from 'react-router-dom';
-import { mockHttpClient, mockAppContext } from '@src/setupTest';
-import { IntlProvider } from '@edx/frontend-platform/i18n';
+import { mockHttpClient, mockAppContext } from '@src/testUtils';
+import { IntlProvider } from '@openedx/frontend-base';


Merge these two @openedx/frontend-base imports. They're non-adjacent, so the earlier sweep missed them; this is the last file with two.

arbrandes · 2026-09-03T17:41:48Z

+
+This directory contains the slots that this frontend app _offers_ for host sites to customize. Slots are implemented with the `<Slot />` component from [`@openedx/frontend-base`](https://github.com/openedx/frontend-base); see the [slot naming and lifecycle ADR](https://github.com/openedx/frontend-base/blob/main/docs/decisions/0009-slot-naming-and-lifecycle.rst) for the API and conventions.
+
+Slots that this app _uses_ from other packages are declared in `src/slots.tsx`.


Drop this line - src/slots.tsx doesn't exist, so it points readers at a dead path.

arbrandes · 2026-09-03T17:41:48Z

+    "react-intl": "6.8.9"
+  },
+  "dependencies": {
+    "@edx/brand": "npm:@openedx/brand-openedx@^1.2.3",


Remove @edx/brand - nothing in the repo imports it (the dev harness gets branding via @openedx/frontend-base/shell/style), so as a hard dependency it just makes every consumer install a brand alias they don't use. lodash.debounce and react-error-boundary moving here was right.

arbrandes · 2026-09-03T17:41:48Z

-    "ts-jest": "^29.4.5"
+    "@types/react-helmet": "^6.1.11",
+    "nodemon": "^3.1.14",
+    "ts-jest": "^29.4.5",


ts-jest isn't referenced by jest.config.js or babel.config.js, and neither frontend-app-catalog nor frontend-app-instructor-dashboard carries it.

arbrandes · 2026-09-03T17:41:48Z

+  "overrides": {
+    "react-intl": "6.8.9"
+  },


This should go away, and the repo fixed up for the version frontend-base provides.

jesusbalderramawgu · 2026-09-03T20:44:37Z

Thanks! Next round!

comments addressed! thank you!

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 19, 2026

jesusbalderramawgu requested a review from jacobo-dominguez-wgu August 19, 2026 17:32

openedx-webhooks added this to Contributions Aug 19, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Aug 19, 2026

jesusbalderramawgu requested a review from arbrandes August 19, 2026 17:32

bradenmacdonald reviewed Aug 19, 2026

View reviewed changes

Comment thread src/authz-module/components/TableControlBar/types.ts Outdated

Comment thread src/authz-module/components/TableCells.test.tsx Outdated

mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Aug 19, 2026

mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Aug 19, 2026

This was referenced Aug 20, 2026

Convert the app to frontend-base #211

Open

Use semicolons, not commas, for TypeScript member delimiters openedx/frontend-base#296

Closed

jesusbalderramawgu mentioned this pull request Aug 24, 2026

feat!: use semicolons for TypeScript member delimiters openedx/frontend-base#297

Merged

jesusbalderramawgu requested a review from bradenmacdonald August 25, 2026 21:23

jesusbalderramawgu force-pushed the frontend-base branch from 16fc5eb to 6150e8e Compare August 25, 2026 21:51

arbrandes requested changes Sep 2, 2026

View reviewed changes

arbrandes reviewed Sep 2, 2026

View reviewed changes

Comment thread package.json Outdated

jesusbalderramawgu added 11 commits September 2, 2026 15:34

feat: frontend app migrated to frontend base

d92096f

feat: missing updates to migration added

30bbf2f

fix: complete frontend-base migration react helmet added

d3b901f

feat: missing files added to migration

0ec06f3

chore: relative imports moved to src alias

daf13ba

refactor: tests updated to avoid boilerplate

0cedbd6

chore: commas changed for semicolons to follow the pattern

3c7f56f

fix: missing file updated

1751e99

build: add package-lock.json (lockfileVersion 3)

998f246

fix: codecov test coverage

f642b0d

feat: Maint test added

5e96bc4

jesusbalderramawgu added 2 commits September 2, 2026 15:38

feat: routes tests added

7871c79

fix: comments addressed with improvements

877a882

jesusbalderramawgu force-pushed the frontend-base branch from 2c0f5cd to 877a882 Compare September 2, 2026 21:39

fix: package-lock updated

a8d90af

jesusbalderramawgu requested a review from arbrandes September 2, 2026 21:50

arbrandes requested changes Sep 3, 2026

View reviewed changes

fix: improvements added

758e7f6

jesusbalderramawgu requested a review from arbrandes September 3, 2026 20:44


		This directory contains the slots that this frontend app _offers_ for host sites to customize. Slots are implemented with the `<Slot />` component from [`@openedx/frontend-base`](https://github.com/openedx/frontend-base); see the [slot naming and lifecycle ADR](https://github.com/openedx/frontend-base/blob/main/docs/decisions/0009-slot-naming-and-lifecycle.rst) for the API and conventions.

		Slots that this app _uses_ from other packages are declared in `src/slots.tsx`.

Uh oh!

Conversation

jesusbalderramawgu commented Aug 19, 2026 • edited by arbrandes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How I have tested this change?

Screenshots

Uh oh!

openedx-webhooks commented Aug 19, 2026

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jesusbalderramawgu commented Aug 25, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arbrandes commented Sep 2, 2026

Uh oh!

jesusbalderramawgu commented Sep 2, 2026

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jesusbalderramawgu commented Aug 19, 2026 •

edited by arbrandes

Loading

codecov Bot commented Aug 25, 2026 •

edited

Loading