Skip to content

Use semicolons, not commas, for TypeScript member delimiters #296

Description

@arbrandes

Description

frontend-base's shared ESLint config requires commas as TypeScript member delimiters, where semicolons are the language standard and what @openedx/eslint-config enforced. Every repo migrating to frontend-base has to rewrite its interfaces, and the divergence looks incidental rather than deliberate.

Raised in openedx/frontend-app-admin-console#210 (comment).

Proposed resolution: switch the rule to semicolons and auto-fix frontend-base. No warning-only period; warnings pile up unactioned and this repo treats them as errors anyway.

Breaking change?

Recommended yes. Consumers inherit the rule from frontend-base, so upgrading reddens their lint run with no change on their side. That warrants a major, with the one-command remedy named in the release notes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions