feat: Add deprecation warning to code owner celery task decorator - #550
Closed
rahulkanneri-2u wants to merge 1 commit into
Closed
Conversation
Adds a DeprecationWarning and a monitoring custom attribute to set_code_owner_attribute / set_code_owner_attribute_from_module, to signal the upcoming removal and give visibility into which callers still use it before it is removed. Refs openedx#469
Contributor
|
@rahulkanneri-2u Please update the ticket reference to github ticket id. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a DeprecationWarning and a monitoring custom attribute to set_code_owner_attribute / set_code_owner_attribute_from_module, to signal the upcoming removal and give visibility into which callers still use it before it is removed.
Refs #469
Description:
Adds a
DeprecationWarningand adeprecated_code_owner_celery_monitoringmonitoring custom attribute insideset_code_owner_attribute/set_code_owner_attribute_from_module. This is purely additive (no behavior change) and gives downstream teams a signal, plus dashboard visibility into which modules still call the decorator, ahead of its eventual removal.JIRA:
#469
Dependencies:
None.
Merge deadline:
None currently. The Willow branch cut was delayed to early January 2027, so there's no immediate deadline pressure on this change.
Installation instructions:
None.
Testing instructions:
@set_code_owner_attribute(or callset_code_owner_attribute_from_moduledirectly).DeprecationWarningto be raised, and adeprecated_code_owner_celery_monitoringcustom attribute to be set with the calling module name.test_set_code_owner_attribute_deprecation_warning,test_set_code_owner_attribute_from_module_deprecation_warning, andtest_set_code_owner_attribute_from_module_deprecated_custom_attributeintest_utils.py.Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.