chore: Remove non-celery code owner monitoring code and docs - #551
Open
rahulkanneri-2u wants to merge 1 commit into
Open
chore: Remove non-celery code owner monitoring code and docs#551rahulkanneri-2u wants to merge 1 commit into
rahulkanneri-2u wants to merge 1 commit into
Conversation
Removes the CodeOwnerMonitoringMiddleware, its supporting utilities, and the new_relic_search.py script/docs, since this web-request-based monitoring is 2U-specific and has already been replaced by plugin-based instrumentation. The celery task decorator (set_code_owner_attribute) and its shared helpers are intentionally left in place, since it is still in active use and its removal is tracked separately. Refs openedx#469
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the non-celery code owner monitoring code, docs, and the new_relic_search script, since this functionality is 2U-specific and has already been replaced by plugin-based instrumentation. The celery task decorator (set_code_owner_attribute) and its shared helpers are intentionally left in place, since it is still in active use and its removal is tracked separately.
Description:
Removes
CodeOwnerMonitoringMiddlewareand its supporting non-celery utilities, tests, and docs, plus thenew_relic_search.pyscript and its docs. This is a trimmed-down replacement for #547, which mixed in premature removal ofutils.py(the still-in-use celery decorator,set_code_owner_attribute). This PR leavesutils.py,test_utils.py, and the celery-related ADRs untouched.JIRA:
#469
Dependencies:
None.
Merge deadline:
None currently.
Installation instructions:
None.
Testing instructions:
None.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.