chore: Remove deprecated code owner utilities and related tests - #547
chore: Remove deprecated code owner utilities and related tests#547ktyagiapphelix2u wants to merge 2 commits into
Conversation
robrap
left a comment
There was a problem hiding this comment.
Some high-level feedback:
- We need to determine whether we will add a deprecation warning before doing this removal.
- We want to mark outdated ADRs as obsolete and add a new one to detail why, but ADRs shouldn't be removed.
@robrap I’m a bit unclear on this as well. From the original ticket https://2u-internal.atlassian.net/browse/BOMS-241, my understanding was that the deprecation warning should be added after the cleanup/removal work is completed. Could you clarify what we need to determine before proceeding with the removal, and whether we’re expected to add the deprecation warning before the cleanup instead? |
We can't have a deprecation warning for something that doesn't exist, so it needs to be added before the functionality is deleted. It is the first step, and it also read "possibly after edx-platform clean-up", which I'm not sure why I added, but meant that we could begin removing uses in |
|
[inform] The DEPR task list (#469) now clarifies what parts of this PR are unblocked and what is blocked. The blocked parts need to be removed for this to move forward. |
WARNING
The DEPR task list (#469) now clarifies what parts of this PR are unblocked and what is blocked. The blocked parts need to be removed for this to move forward.
Summary
Ticket
https://2u-internal.atlassian.net/browse/BOMS-241