Conversation
The CMake config files contain the following instruction:
```
include("${CMAKE_CURRENT_LIST_DIR}/arpackngTargets.cmake")
```
The file `arpackngTargets.cmake` is generated by CMake. It is not
generated by the Makefile rules (nor by the `configure` script).
That means that trying to use the CMake config files in downstream CMake
projects leads to a fatal error like the following:
```
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/arpack-ng/arpackng-config.cmake:35 (include):
include could not find requested file:
```
CMake does not support catching fatal errors and continuing execution.
That means that the configuration for downstream projects bails at that
point even if ARPACK-ng is actually correctly installed (apart from the
broken CMake config files).
On the other hand, if no CMake config files are installed at all, CMake
determines that gracefully in downstream projects. If that should happen,
these projects can fall back to alternative ways to locating ARPACK-ng
(e.g., using the pkg-config files or looking at default locations).
This reverts opencollab#438 to avoid this error.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
|
Some of the package repositories seem to have connection problems currently. (Maybe also caused by AI scrapers like in so many other places?) The proposed changes shouldn't cause any difference in the tests though. And for what they do, they aren't platform dependent. So, if it does the correct thing in one of the autotools jobs (and apparently it does), it will also do it in the other ones. |
Contributor
Author
|
@sylvestre: Does this look ok to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request purpose
The CMake config files contain the following instruction:
The file
arpackngTargets.cmakeis generated by CMake. It is not generated by the Makefile rules (nor by theconfigurescript).That means that trying to use the CMake config files in downstream CMake projects leads to a fatal error like the following:
CMake does not support catching fatal errors and continuing execution. That means that the configuration for downstream projects bails at that point even if ARPACK-ng is actually correctly installed (apart from the broken CMake config files).
On the other hand, if no CMake config files are installed at all, CMake determines that gracefully in downstream projects. If that should happen, these projects can fall back to alternative ways to locating ARPACK-ng (e.g., using the pkg-config files or looking at default locations).
Detailed changes proposed in this pull request
This reverts #438 to avoid this error.