configure should still install cmake files - #438
Merged
Merged
Conversation
Contributor
|
The CMake config files cannot be used on their own. They include the following line: arpack-ng/cmake/arpackng-config.cmake.in Line 35 in 947a004 The file CMake doesn't support catching fatal errors and continuing execution. On the other hand, if no CMake config files would be installed at all, CMake determines that gracefully in downstream projects, and they can fall back to alternative ways to locating ARPACK-ng. See, e.g., ElmerCSC/elmerfem#907 where this came up with the version of ARPACK-ng that is distributed by Debian. That version is apparently built using the Makefile rules. Would it be ok to revert this change? |
mmuetzel
added a commit
to mmuetzel/arpack-ng
that referenced
this pull request
Sep 4, 2026
The CMake config files contain the following instruction:
```
include("${CMAKE_CURRENT_LIST_DIR}/arpackngTargets.cmake")
```
The file `arpackngTargets.cmake` is generated by CMake. It is not
generated by the Makefile rules (nor by the `configure` script).
That means that trying to use the CMake config files in downstream CMake
projects leads to a fatal error like the following:
```
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/arpack-ng/arpackng-config.cmake:35 (include):
include could not find requested file:
```
CMake does not support catching fatal errors and continuing execution.
That means that the configuration for downstream projects bails at that
point even if ARPACK-ng is actually correctly installed (apart from the
broken CMake config files).
On the other hand, if no CMake config files are installed at all, CMake
determines that gracefully in downstream projects. If that should happen,
these projects can fall back to alternative ways to locating ARPACK-ng
(e.g., using the pkg-config files or looking at default locations).
This reverts opencollab#438 to avoid this error.
mmuetzel
added a commit
to mmuetzel/arpack-ng
that referenced
this pull request
Sep 4, 2026
The CMake config files contain the following instruction:
```
include("${CMAKE_CURRENT_LIST_DIR}/arpackngTargets.cmake")
```
The file `arpackngTargets.cmake` is generated by CMake. It is not
generated by the Makefile rules (nor by the `configure` script).
That means that trying to use the CMake config files in downstream CMake
projects leads to a fatal error like the following:
```
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/arpack-ng/arpackng-config.cmake:35 (include):
include could not find requested file:
```
CMake does not support catching fatal errors and continuing execution.
That means that the configuration for downstream projects bails at that
point even if ARPACK-ng is actually correctly installed (apart from the
broken CMake config files).
On the other hand, if no CMake config files are installed at all, CMake
determines that gracefully in downstream projects. If that should happen,
these projects can fall back to alternative ways to locating ARPACK-ng
(e.g., using the pkg-config files or looking at default locations).
This reverts opencollab#438 to avoid this error.
Contributor
|
I opened #492 that reverts this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.