Repository navigation
chore(autoreview): use the shared canonical skill - #63
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review in progressClawSweeper is reviewing this revision. This supersedes any previous blocked status. |
|
Codex review: needs changes before merge. Reviewed October 6, 2026, 4:38 AM ET / 08:38 UTC (Revision 11). ClawSweeper reviewWhat this changesReplace ClawScan’s copied review helper and tests with a shared skill entrypoint, and update contributor instructions and the changelog. Merge readiness⛔ Needs changes before merge - 1 item remains The shared-install cutover remains useful: current main and the latest release still vendor the helper. No actionable patch defect was found, and this MEMBER-authored PR must remain open for its owner to land. Priority: P3 Review scores
Verification
How this fits togetherAutoreview is a contributor tool that reviews repository changes before handoff. This change directs contributors to an installed shared helper while keeping ClawScan’s review requirements local. flowchart TD
A[Repository changes] --> B[Local review instructions]
B --> C[Shared skill installed]
C -->|Missing| D[Documented installation]
D --> E[Shared review helper]
C -->|Available| E
E --> F[Structured review results]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep one upstream review implementation with explicit installation guidance and repository-specific requirements preserved in ClawScan. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a tooling consolidation, and source inspection confirms the copied helper remains on current main. Is this the best way to solve the issue? Yes: the shared installer and helper already support installation outside the consumer repository while reviewing its working directory, avoiding another local implementation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 490bd167ea43. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (10 earlier review cycles; latest 8 shown)
|
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.