fix(runner): quote docker mount fields that contain commas

[SebTardif]

What Problem This Solves

docker --mount is CSV, so a path containing a comma split the mount and
broke every sandboxed scanner. Quote each field the way Docker's CSV
parser expects.

Why This Change Was Made

This patch is limited to the files below.

• internal/runner/runner_test.go
• internal/runner/sandbox.go

User Impact

The case described above now follows the patched behavior. Existing commands and configuration stay in place.

Evidence

Patched commit b5ff8ffe05af66eb54edc5c9a770c10b294b1d97 on fix/clawscan-f004 in /tmp/oc-batch/clawscan.

$ cd /tmp/oc-batch/clawscan && go test -count=1 -timeout 180s -run TestDockerMounts ./internal/runner/
pass (exit 0, ok github.com/openclaw/clawscan/internal/runner)

Real behavior proof

• Behavior or issue addressed: fix(runner): quote docker mount fields that contain commas
• Real environment tested: macOS, patched tree /tmp/oc-batch/clawscan, commit b5ff8ffe05af
• Exact steps or command run after this patch: cd /tmp/oc-batch/clawscan && go test -count=1 -timeout 180s -run TestDockerMounts ./internal/runner/
• Evidence after fix: terminal output from the patched tree:

$ cd /tmp/oc-batch/clawscan && go test -count=1 -timeout 180s -run TestDockerMounts ./internal/runner/
pass (exit 0, ok github.com/openclaw/clawscan/internal/runner)

• Observed result after fix: pass (exit 0, ok github.com/openclaw/clawscan/internal/runner)
• What was not tested: the upstream hosted runner matrix

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs real behavior proof before merge. Reviewed October 5, 2026, 12:10 AM ET / 04:10 UTC (Revision 3).

ClawSweeper review

What this changes

The PR escapes Docker bind-mount fields containing commas or quotes and adds tests covering path round trips and mount permissions.

Merge readiness

⛔ Blocked before merge - 2 items remain

The fix remains necessary: current main and v0.2.0 still emit unquoted mount fields. No actionable patch defect was found, but the prior request for Docker-backed runtime proof remains outstanding.

Priority: P2
Reviewed head: b5ff8ffe05af66eb54edc5c9a770c10b294b1d97

Review scores

Measure	Result	What it means
Overall readiness	🦪 silver shellfish (2/6)	The patch is focused and source-consistent, but unit-test output alone does not satisfy the runtime-proof gate.
Proof confidence	🦪 silver shellfish (2/6)	Needs real behavior proof before merge: The changed Docker sandbox runner produces --mount arguments, but the captured after-fix transcript exercises only local serialization tests, without Docker or observed container access. The prior runtime-proof request remains outstanding. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Needs proof	Needs real behavior proof before merge: The changed Docker sandbox runner produces --mount arguments, but the captured after-fix transcript exercises only local serialization tests, without Docker or observed container access. The prior runtime-proof request remains outstanding. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed	7 items	Introduced change: The pinned base-to-head diff changes only mount serialization and its regression tests; mount selection and permission decisions remain unchanged. Still needed on main: Current main concatenates source and target directly into comma-delimited fields, without CSV escaping. Its Docker runner passes these strings as individual --mount arguments. Latest release check: The v0.2.0 sandbox implementation also uses unescaped mount-field concatenation; the requested repair is not present in the supplied latest release.
Findings	None	None.
Security	None	None.

How this fits together

ClawScan runs command-backed scanners and judges through a Docker sandbox. The sandbox runner converts target paths, working directories, and explicit mounts into Docker arguments before executing the scanner or judge.

flowchart LR
  A[Scanner or judge command] --> C[Sandbox runner]
  B[Target paths and explicit mounts] --> C
  C --> D[Select mount permissions]
  D --> E[Encode mount fields as CSV]
  E --> F[Docker container]
  F --> G[Scanner or judge output]

Loading

Before merge

• Add real behavior proof - Needs real behavior proof before merge: The changed Docker sandbox runner produces --mount arguments, but the captured after-fix transcript exercises only local serialization tests, without Docker or observed container access. The prior runtime-proof request remains outstanding. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
• Complete next step (P2) - Provide after-fix Docker-backed ClawScan output showing successful access to a comma-containing mounted path. Terminal screenshots, copied output, recordings, or logs count; redact private paths, endpoints, IP addresses, and credentials. Update the PR body to trigger review, or ask a maintainer to comment @clawsweeper re-review.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Production and test delta	production +33/-5 lines; tests +59/-0 lines	Production growth is confined to CSV serialization helpers, with regression coverage for special paths and permissions.

Technical review

Best possible solution:

Keep CSV escaping at the Docker argument boundary while preserving ordinary-path output and existing read-only versus writable mount decisions.

Do we have a high-confidence way to reproduce the issue?

Yes, from source: an existing absolute path containing a comma reaches unescaped --mount construction on main, where Docker interprets the comma as a field separator. No runtime reproduction was executed during this read-only review.

Is this the best way to solve the issue?

Yes. Encoding complete mount fields as CSV matches Docker's parser and repairs the existing argument boundary without changing configuration or mount permissions.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 490bd167ea43.

Labels

Label changes:

No label changes.

Label justifications:

• P2: This repairs sandbox execution for paths containing commas or quotes, with a bounded trigger and no demonstrated urgent regression.
• rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
• status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The changed Docker sandbox runner produces --mount arguments, but the captured after-fix transcript exercises only local serialization tests, without Docker or observed container access. The prior runtime-proof request remains outstanding. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

What I checked:

• Introduced change: The pinned base-to-head diff changes only mount serialization and its regression tests; mount selection and permission decisions remain unchanged. (internal/runner/sandbox.go:256, b5ff8ffe05af)
• Still needed on main: Current main concatenates source and target directly into comma-delimited fields, without CSV escaping. Its Docker runner passes these strings as individual --mount arguments. (internal/runner/sandbox.go:255, 490bd167ea43)
• Latest release check: The v0.2.0 sandbox implementation also uses unescaped mount-field concatenation; the requested repair is not present in the supplied latest release. (internal/runner/sandbox.go, ef02eb65260b)
• Authoritative Docker parsing contract: ClawScan's production runner invokes Docker --mount, establishing a direct dependency on Docker's parser. Docker's MountOpt.Set parses the complete argument with encoding/csv, then splits each decoded field at its first equals sign; quoting the whole field matches this contract. (opts/mount.go:30, 75d1d1a9e62f)
• Proof and review continuity: The captured body supplies only a macOS go test transcript for TestDockerMounts. The new test invokes serialization helpers and Go's CSV reader, without starting Docker. The previous completed review at the same head requested a redacted Docker-backed run accessing a comma-containing mounted path: fix(runner): quote docker mount fields that contain commas #64 (comment). That request remains applicable. (internal/runner/runner_test.go:231, b5ff8ffe05af)
• Mount ownership and security contract: GitHub commit metadata identifies jesse-merhi as the author of the merged explicit-mount work in sec (8/9): replace writable-parent mount guess with explicit sandbox mounts #32. Its patch establishes operator-selected writable mounts and read-only target mounts. The current PR preserves those decisions. Local history traversal and blame encountered unavailable promisor objects; GitHub commit inspection supplied the bounded history evidence. (internal/runner/sandbox.go:247, a9b45ab69396)

Likely related people:

• jesse-merhi: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

• Add a redacted after-fix transcript showing a Docker-backed ClawScan command successfully accesses a mounted path containing a comma.

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (2 earlier review cycles)

• reviewed 2026-10-04T02:47:01.147Z sha b5ff8ff :: needs real behavior proof before merge. :: none
• reviewed 2026-10-04T21:23:39.552Z sha b5ff8ff :: needs real behavior proof before merge. :: none