Skip to content

fix: prevent special character corruption with explicit escaping encodings #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussH merged 2 commits into from
Mar 17, 2026
Merged

fix: prevent special character corruption with explicit escaping encodings #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b5517
Add explicit charset to XML AJAX responses
anonymoususer72041 Jan 23, 2026
f1fc1e8
Pass explicit encoding to htmlspecialchars in job order AJAX XML output
anonymoususer72041 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ajax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@

if (!isset($_REQUEST['f']) || empty($_REQUEST['f']))
{
header('Content-type: text/xml');
header('Content-type: text/xml; charset=' . AJAX_ENCODING);
echo '<?xml version="1.0" encoding="', AJAX_ENCODING, '"?>', "\n";
echo(
"<data>\n" .
Expand Down Expand Up @@ -125,7 +125,7 @@

if (!is_readable($filename))
{
header('Content-type: text/xml');
header('Content-type: text/xml; charset=' . AJAX_ENCODING);
echo '<?xml version="1.0" encoding="', AJAX_ENCODING, '"?>', "\n";
echo(
"<data>\n" .
Expand Down
6 changes: 3 additions & 3 deletions ajax/getDataItemJobOrders.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@
$output .=
" <joborder>\n" .
" <id>" . $jobOrdersArray[$rowIndex]['jobOrderID'] . "</id>\n" .
" <title>" . htmlspecialchars($jobOrdersArray[$rowIndex]['title']) . "</title>\n" .
" <companyname>" . htmlspecialchars($jobOrdersArray[$rowIndex]['companyName']) . "</companyname>\n" .
" <assigned>" . htmlspecialchars($jobOrdersArray[$rowIndex]['isAssigned']) . "</assigned>\n" .
" <title>" . htmlspecialchars($jobOrdersArray[$rowIndex]['title'], ENT_COMPAT, AJAX_ENCODING) . "</title>\n" .
" <companyname>" . htmlspecialchars($jobOrdersArray[$rowIndex]['companyName'], ENT_COMPAT, AJAX_ENCODING) . "</companyname>\n" .
" <assigned>" . htmlspecialchars($jobOrdersArray[$rowIndex]['isAssigned'], ENT_COMPAT, AJAX_ENCODING) . "</assigned>\n" .
" </joborder>\n";
}

Expand Down
2 changes: 1 addition & 1 deletion lib/AJAXInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class AJAXInterface
*/
public function outputXMLPage($xmlString)
{
header('Content-type: text/xml');
header('Content-type: text/xml; charset=' . AJAX_ENCODING);

echo '<?xml version="1.0" encoding="', AJAX_ENCODING, '"?>', "\n";
echo $xmlString;
Expand Down
Loading