Repository navigation
Conversation
…its tenor - A print that is the only observation at its tenor no longer supplies its own node, so it cannot force flat extrapolation or a zero mark - A print that shares its tenor keeps the pair's shared curve - Observations carry the dissemination identifier - observation_curve builds the curve from extracted observations; ndf_forward_curve delegates to it - fx-pair and fx-df memo keys carry the curve date Signed-off-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
- scrub_string assigned the return value of dict.update, which is None, so every scrubbed header became None - vcrpy 9 cannot replay a None header value, which failed test_cftc_cot_fetcher and test_cftc_cot_sarch_fetcher and left cot.py below the 100% coverage gate Signed-off-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
- ty 0.0.100 renamed the rule and exits 1 on the old name, which failed the Lint (ruff + ty) job Signed-off-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
- ObservationCurve builds a pair's forward curve once and leaves one print's observation out in O(tenor nodes) - fx_market leaves the valued print out of the curve for every forward, not only prints alone at their tenor - A print whose identifier is blank or repeated is not left out - observation_curve wraps ObservationCurve; the vol surface is unchanged Signed-off-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ObservationCurve.curve(without=<dissemination identifier>)leaves that print's observation out of its tenor node and the near-tenor spot pool in O(tenor nodes).fx_marketuses it for every forward.fx-pairandfx-dfmemo keys carry the curve date.observation_curvewrapsObservationCurve;ndf_forward_curveand the vol surface are unchanged.dissemination_identifier.CI fixes (own commits)
tests/conftest.py:scrub_stringassigned the return value ofdict.update(None) to the header. vcrpy 9 cannot replay aNoneheader, which failedtest_cftc_cot_fetcherandtest_cftc_cot_sarch_fetcherand leftcot.pybelow the 100% coverage gate.pyproject.toml:ty0.0.100 renamedunresolved-importtoimport-not-foundand exits 1 on the old name.Evidence
Data: DTCC forex and rates slices for 2026-11-05, 11-06, 11-09, 11-10 (downloaded) and 2026-10-09 (local cache): 220,285 forwards and 4,777 options. Every priceable print is valued with one memo per day, as
_keep_priceable_forexdoes. CNY curve extras are not fetched.Reference ("exact"): the same code with that print's own record removed from the pair's records. It covers every forward on 2026-10-09 and a random 21% to 59% of the other days (99,568 of 220,285 forwards, 45%).
Market rate against the reference, pooled over the 98,794 checked forwards, by number of prints at the forward's tenor:
"Identical" is bit-identical floats on all 98,794. A zero mark is a market rate equal to the traded rate.
All 220,285 forwards, #7750 against this PR:
Other checks:
_keep_priceable_forex6.15-6.52 s and 7.31-7.76 s.ruff check,ruff format --checkandty checkpass.Known limits