Repository navigation
Conversation
…its tenor - A print that is the only observation at its tenor no longer supplies its own node, so it cannot force flat extrapolation or a zero mark - A print that shares its tenor keeps the pair's shared curve - Observations carry the dissemination identifier - observation_curve builds the curve from extracted observations; ndf_forward_curve delegates to it - fx-pair and fx-df memo keys carry the curve date Signed-off-by: dlee-bq <325002271+dlee-bq@users.noreply.github.com>
Contributor
|
Invalid branch name for a Pull Request to be merged to branch. Branches must follow the GitFlow naming convention. Please review our branch naming guidelines. |
Contributor
Author
|
Superseded by #7833: branch name did not match the GitFlow check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MIN_FORWARD_NODES = 2, a thin pair's own print could supply a node, forcing flat extrapolation and a mark near zero.fx-pairandfx-dfmemo keys carry the curve date, likefx-curve,fx-marketandfx-options.observation_curvebuilds the curve from extracted observations;ndf_forward_curvedelegates to it, so the vol surface is unchanged.dissemination_identifier, which identifies a print's own observation.Not in this PR
fx_implied_volandfx_market(notional floor,min_trades, forward-aware discounting, spot rule,days > 2/days <= 9cut-offs).Known limit
How has this been tested?
tests/test_fx_valuation.py: 98 passed. Added tests for a print alone at its tenor, a print sharing its tenor, no leak to the pair's other prints, an empty identifier, and date-carrying memo keys.tests/test_search_http.py(needsvcr, not installed locally).