i18n: localize the native tray menu - #257
Merged
Merged
Conversation
The tray ("Show QlipLab" / "Quit") is built in Rust at startup, before the
webview and i18n exist, so it was always English. Added a
`set_tray_labels(show, quit)` command that relabels the kept menu-item
handles; the frontend calls it once i18n initialises and again on every
`languageChanged`, so the tray follows the app language.
Rust verified with `cargo check`. i18n: tray.show / tray.quit ×15 (the
brand name QlipLab stays in "Show QlipLab").
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tray ("Show QlipLab" / "Quit") is built in Rust at startup, before the webview and i18n exist — so it was permanently English.
Fix
MenuItemhandles in managed state; add aset_tray_labels(show, quit)command that callsset_texton them. Verified withcargo check.Appcalls it once i18n initialises and again on everylanguageChanged, so the tray follows the app language.i18n:
tray.show/tray.quit×15 (brand name stays in "Show QlipLab").tscclean · 608 tests green.🤖 Generated with Claude Code