fix: remove stale patch-package postinstall#956
Open
999axel999 wants to merge 8 commits into
Open
Conversation
Signed-off-by: 999axel999 <62794205+999axel999@users.noreply.github.com>
Member
|
@999axel999 please, fix merge conflicts |
Member
|
@999axel999 this change looks weird: you don't change anything, just deleting what works. Apparently, CI is clean after your changes, but this most probably means that CI is weak. |
Author
|
@yegor256 I reworked the PR after your feedback. It no longer relies on a blind deletion: the branch now bumps the EO parser from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patch-package/grunt-mocha-clipostinstall hook and its unused devDependency.scripts/postinstall.jswith a#939TODO documenting the follow-up Windows-shell investigation instead of silently deleting the context.0.61.0to0.61.1, which fixes the parser-side failure that made the earlier cleanup look suspicious.Closes #939
Tests
nodeparser smoke check for slash syntax against EO0.61.1.\node_modules\.bin\mocha.cmd test/test_postinstall.js --timeout 1200000npm.cmd exec -- eslint test/test_postinstall.js scripts/postinstall.jsgit diff --check7f3e79777a4f61ad85e5a1901cac42bd93bca6b1:pdd,markdown-lint,copyrights,yamllint,shellcheck,typos,actionlint,eslint,reuse,xcop,itest, andgruntall passed.Prepared with local automation assistance and reviewed before submission.