#939: remove obsolete postinstall patch#958
Closed
akmhatey-ai wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this as duplicate. After opening it I rechecked the current PR queue and confirmed that #949 and #956 already make the same cleanup: remove the obsolete postinstall script, remove the stale grunt-mocha-cli patch, drop patch-package, and update package-lock.json. This PR does not add distinct value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #939.
This removes the obsolete
patch-packagepostinstall path left behind after the project switched fromgrunt-mocha-clitogrunt-mocha-testin #892. The stale script checked fornode_modules/grunt-mocha-cli, which is no longer installed, and the only patch underpatches/also targeted that removed package. Sincegrunt-mocha-testruns Mocha through its library wrapper rather than the old spawned CLI path, there is no equivalent patch target to keep.Changes:
scripts/postinstall.jspatches/grunt-mocha-cli+7.0.0.patchpatch-packagefrom dev dependenciespostinstallpackage scriptValidation:
npm cisucceeds and no longer printsProduction environment detected, skipping patch-package.npx grunt --file=test/test_eoc.js-> 8 passingnpx mocha test/**/*.js --timeout 1200000 --grep eoc-> 9 passingnpx mocha test/test_eoc.js --timeout 1200000-> 8 passingnpx eslint .git diff --checkgitleaks detect --source . --no-banner --redact --log-opts HEADLimitations:
npx gruntwas attempted locally, but this Windows environment does not haveJAVA_HOME/javacconfigured, so Java-backed EO/Maven tests fail before exercising this package cleanup.