Magnifier UI improvement

[CyrilleB79]

Link to issue number:

TBD

Summary of the issue:

Magnifier UX is sometimes not very clear or do not fit NVDA's usual style.

Description of user facing changes:

• Since "Magnifier" and "Vision" are two distinct categories in settings dialog, the Magnifier commands are now listed in "Magnifier" category. "Vision" category remains in case add-on implement vision providers; for now, NVDA has no more native Vision command.
• Command names have been reworded

Description of developer facing changes:

Description of development approach:

The commands have been reworded with the following ideas:

• Commands do not mention "of the magnifier" each time, as we do not mention it either "for browse mode" or "for Remote Access" in their specific commands.
• "magnifier view" becomes "magnified view" in panning commands
• filter -> color filter and toggle -> cycle since there are 3 filters, not only an on/off
• The commands "follow X" are renamed "X tracking"; "follow" can remain in the GUI
• remove "for the full screen magnifier" or "if magnifier is full-screen" since we will have error messages in case no full-screen mode is not active.
• spotlight command rewording

TBD: Update GUI, UI messages and documentation accordingly.

Testing strategy:

Manual testing:

• Checked input help and Input gestures dialog.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[CyrilleB79]

To @Boumtchack, @Qchristensen and other interested parties:
This is a draft PR to make Magnifier command names, GUI labels, UI messages and documentation clearer and more in line with the rest of NVDA wording.
Would you mind have a look at the rewording to know what you already think of the command names before I update other parts (GUI, UI messages and documentation) similarly?
Thanks.

[CyrilleB79]

Also @seanbudd your feedback would be appreciated before I update the rest of the strings/docs.

[seanbudd]

I like the rephrasing - just waiting for Quentin to also confirm

[Boumtchack]

I was thinking that we should have a dedicated gesture for all magnifier:
NVDA+SHIFT+ "any key" will always result in a magnifier gesture.
It doesn't have to be nvda+shift, but I think it could be easier for user to get use to the new gestures (there's many I think) if we have a dedicated gesture for them.

for now I don't know what keyboard combo is free to do that, or if it's ok for you

[CyrilleB79]

I was thinking that we should have a dedicated gesture for all magnifier: NVDA+SHIFT+ "any key" will always result in a magnifier gesture. It doesn't have to be nvda+shift, but I think it could be easier for user to get use to the new gestures (there's many I think) if we have a dedicated gesture for them.

for now I don't know what keyboard combo is free to do that, or if it's ok for you

I'd prefer keep this PR around UI strings (UI messages, GUI, documentation) where, I think, a general agreement can be found easily (hence the modifications directly suggested in a PR and not in an issue or a discussiion).

On the opposite, I expect that gesture assignment lead to more discussion; some poeple have already complained about too many gestures assigned for Magnifier while only few NVDA users use it. That's not my position though.

But I prefer that to keep things clear, we discuss it in a separate dedicated thread (issue or discussion) to avoid clutering this PR. Feel free to open it. Thanks.

[Boumtchack]

I think "spolight" might not be good wording.
there is no spolight around the mouse cursor or the focus, it's only a dezoom + zoom.
we could either change the name to "global view" or to specifiy it's not implemented atm?
I totally forgot about this one. I kept the name because it was what was originally itenended to do

[CyrilleB79]

I think "spolight" might not be good wording. there is no spolight around the mouse cursor or the focus, it's only a dezoom + zoom. we could either change the name to "global view" or to specifiy it's not implemented atm? I totally forgot about this one. I kept the name because it was what was originally itenended to do

OK. Thanks for this feedback. I was not very comfortable myself with this name. I'll try to suggest other(s) name(s) and wording tomorrow.

[Qchristensen]

I agree changing this name could be worthwhile. I haven't got a perfect name off the top of my head, but am open to suggestions

[Qchristensen]

I agree changing this name could be worthwhile. I haven't got a perfect name off the top of my head, but am open to suggestions