Change Magnifier settings into a more organised way by Boumtchack · Pull Request #19913 · nvaccess/nvda

Boumtchack · 2026-04-07T09:19:24Z

Link to issue number:

pre - #19473
parts of #19810

Summary of the issue:

#19810 was still to big so I focused on settingsDiallogs

Description of user facing changes:

Magnifier setttings will be better ordred with sections according to each categories

Description of developer facing changes:

Used groupbox to create groups

Description of development approach:

Separation of General settings that will impact all magnifiers, Magnifier types with their specific settings, placeholder for focus type group.

Testing strategy:

Unit

Known issues with pull request:

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

Copilot

Pull request overview

Reorganizes the Magnifier settings panel UI to better group related settings (General / Focus / Fullscreen) using static group boxes.

Changes:

Introduces grouped sections in the Magnifier settings panel (General, Focus, Fullscreen).
Renames/restructures several Magnifier controls and their associated help bindings.
Adds placeholder UI entries for future “Focus” tracking options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

seanbudd · 2026-04-07T23:09:22Z

@Boumtchack - please provide a descriptive title

seanbudd · 2026-04-07T23:36:03Z

Let's focus on #19732 #19739 #19780 #19882 for now. Once most of these are merged, we can work on #19473 #19915 and #19913. Otherwise, there's too much conflicts between the different PRs. We want to ensure work which has already started gets completed before new work is started.

seanbudd · 2026-05-12T00:29:22Z

I think work on this should be blocked/suspended until #20050 is merged

seanbudd · 2026-05-28T05:45:05Z

#20050 has been merged now, so this is unblocked

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

CyrilleB79 · 2026-06-02T06:29:48Z

 		# Translators: The label for a setting in magnifier settings to select whether true center is used in full-screen mode
-		trueCenterText = _("Use &true center in fullscreen mode")
-		self.trueCenterCheckBox = sHelper.addItem(wx.CheckBox(self, label=trueCenterText))
+		trueCenterText = _("Use &true center")


I feel that calling the feature "True center tracking" is much clearer than only "True center" which is not very clear. By the way, it's called "True center tracking" in Zoomtext too, from where the feature has been copied.

Also, optionally, I'd remove "Use" since there is no need to overload GUI labels/text. It's already clear, when we have a checkbox labeled with just a feature name, that checking it means "Use feature X". E.g. we already have no problem these options which haven't "Use':

"Automatic language switching"

"Blink cursor" (in braille settings)

"Simple review mode"

Suggested change

trueCenterText = _("Use &true center")

trueCenterText = _("&true center tracking")

Or if you disagree with "Use" removal:

Suggested change

trueCenterText = _("Use &true center")

trueCenterText = _("Use &true center tracking")

Note:

@seanbudd "in full screen" has been removed because the checkbox is now in the "Full-screen" group, so no need to overload the GUI repeating it. I fully agree with this removal.

I was about to suggest name change / improvement in Magnifier UI improvement #20261 but if you change it already here, it's OK.

"in full screen" has been removed because the checkbox is now in the "Full-screen" group, so no need to overload the GUI repeating it. I fully agree with this removal.

But it hasn't? the setting is in general group

But it hasn't? the setting is in general group

Oh sorry, you're right.
In any case, "full-screen" should not be in the label since we have a "full-screen" group:

either the feature applies to full-screen mode only and it should be moved in the "full-scren" group

or it applies to more than one mode (e.g. maybe fixed or docked can support it); in this case it remains in general group but it become incorrect to add "full-screen" in the label

there's two settings that might get mistake:

true center, wich change the screen to make the mouse/focus appear at the center of the physicall screen. This one is global

Keep mouse center, move the mouse so it stays at the center of the screen while moving, to prevent it getting out of the magnifier view. This is the one is Fullscreen only.

maybe the last one can be replaced by a gesture to get the mouse back into the frame as mentionned in an other comment

i'll change it to true center tracking

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

seanbudd · 2026-06-04T03:55:16Z

 | Grayscale | Converts all colors to shades of gray, which can help reduce eye strain and improve contrast. |
 | Inverted | Inverts all colors on the screen, which can be helpful for users who prefer light text on dark backgrounds or have photophobia. |

 ##### Focus mode {#MagnifierFullscreenFocusMode}


This needs to be moved down further to match the move in settings dialog

seanbudd · 2026-06-04T03:56:16Z

 | Border | The magnified area only moves when the focus approaches the edge of the visible area. |
 | Relative | The magnified area maintains the relative position of the focus within the screen. |

+##### Use true center tracking {#MagnifierUseTrueCenterTracking}


doesn't this need to be moved further down too?

initial commit

c4f4777

Boumtchack marked this pull request as ready for review April 7, 2026 09:28

Boumtchack requested a review from a team as a code owner April 7, 2026 09:28

Boumtchack requested review from Copilot and seanbudd April 7, 2026 09:28

Copilot started reviewing on behalf of Boumtchack April 7, 2026 09:29 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

copilot review

541952b

Boumtchack requested a review from a team as a code owner April 7, 2026 09:58

Boumtchack requested a review from Qchristensen April 7, 2026 09:58

seanbudd marked this pull request as draft April 7, 2026 23:09

seanbudd mentioned this pull request Apr 7, 2026

preparing the new magnifier types #19915

Merged

5 tasks

seanbudd closed this Apr 7, 2026

seanbudd changed the title ~~initial commit~~ [needs descriptive title] Apr 20, 2026

seanbudd reopened this Apr 20, 2026

Boumtchack changed the title ~~[needs descriptive title]~~ Change Magnifier settings into a more organised way Apr 21, 2026

Boumtchack added 2 commits April 21, 2026 11:03

Merge branch 'master' into MagnifierSettingsRework

bf293c2

Merge branch 'master' into MagnifierSettingsRework

383c842

seanbudd changed the base branch from master to beta May 11, 2026 08:21

seanbudd added this to the 2026.2 milestone May 11, 2026

seanbudd changed the base branch from beta to master May 11, 2026 09:32

seanbudd changed the base branch from master to beta May 11, 2026 09:33

Boumtchack added 2 commits June 1, 2026 15:44

Merge branch 'beta' into MagnifierSettingsRework

761ec45

restore user_docs to beta

4aa527c

Boumtchack marked this pull request as ready for review June 1, 2026 14:41

Boumtchack requested a review from Copilot June 1, 2026 14:42

Copilot AI reviewed Jun 1, 2026

View reviewed changes

copilot review

1f1bead

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 1, 2026

seanbudd reviewed Jun 2, 2026

View reviewed changes

Comment thread source/gui/settingsDialogs.py

Comment thread source/gui/settingsDialogs.py

Comment thread source/gui/settingsDialogs.py

Comment thread source/gui/settingsDialogs.py

Comment thread source/gui/settingsDialogs.py

seanbudd marked this pull request as draft June 2, 2026 01:47

CyrilleB79 reviewed Jun 2, 2026

View reviewed changes

Boumtchack added 3 commits June 2, 2026 11:25

reorder and true center tracking

784092e

true center tracking in settings

3576b75

Merge branch 'beta' into MagnifierSettingsRework

9fe3a45

Boumtchack marked this pull request as ready for review June 3, 2026 07:44

Boumtchack requested a review from Copilot June 3, 2026 07:46

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread source/gui/settingsDialogs.py

Comment thread user_docs/en/userGuide.md Outdated

userdoc update

eba87c2

Boumtchack mentioned this pull request Jun 3, 2026

Clarity improvement in magnifier naming #20281

Draft

5 tasks

seanbudd reviewed Jun 4, 2026

View reviewed changes

seanbudd marked this pull request as draft June 4, 2026 03:56

	trueCenterText = _("Use &true center")
	trueCenterText = _("&true center tracking")

	trueCenterText = _("Use &true center")
	trueCenterText = _("Use &true center tracking")

Uh oh!

Conversation

Boumtchack commented Apr 7, 2026

Link to issue number:

Summary of the issue:

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanbudd commented Apr 7, 2026

Uh oh!

seanbudd commented Apr 7, 2026

Uh oh!

seanbudd commented May 12, 2026

Uh oh!

seanbudd commented May 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CyrilleB79 Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

seanbudd Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

CyrilleB79 Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Boumtchack Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Boumtchack Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

seanbudd Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

seanbudd Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects