Skip to content

feat: add haptic feedback when blocking and unblocking - #115

Merged
ykisana merged 1 commit into
normalengineering:mainfrom
noahweidig:test/admiring-wright-25r5wv
Nov 18, 2026
Merged

ykisana merged 1 commit into
normalengineering:mainfrom
noahweidig:test/admiring-wright-25r5wv

Conversation

@noahweidig

@noahweidig noahweidig commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What

  • A medium impact haptic plays after any block or unblock goes through:
    • Home: Block All, Unblock All and Block All Now.
    • Group cards: Block, Unblock and Block Now.
    • Unlock links and widgets.
    • Shortcuts, when Normal is open.
    • Emergency unblock.
  • It plays after the change succeeds, so a failed unblock or a cancelled key check plays nothing.
  • There's no in-app setting. Turning off System Haptics in iOS Settings › Sounds & Haptics already silences it, as it does the haptics iOS plays for toggles and pickers.

How

  • BlockActions plays it at the end of blockAll, blockGroup, unblock and emergencyUnblock, so every path that changes what's blocked gets it.
  • Home's Block All Now called TimedUnblockService.cancelMain directly. It now calls Home's blockMain, the same BlockActions.blockAll as Block All, which already clears every timed unblock before blocking. The test harness's blockAllNow() does the same.

Tests

  • Unit tests: 884/884 on the iPhone Air iOS 27.0 simulator.
  • UI tests: 47/47 before Block All Now moved to blockMain. The 21 Blocking ones, which include Block All Now, pass after it.
  • Tried on an iPhone 17: the haptic plays on block and unblock.

@ykisana

ykisana commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Hey thanks for the contribution! Can you update this PR so it just has the haptic feedback, not the funding stuff. Also this will just update for main unblock/block all button. Maybe this should exist in the central blocking/unblocking logic.

Also should add a setting in the settings to turn this on/off.

I can take over this PR, sometime tmw if you don't have availability for these changes.

@noahweidig

Copy link
Copy Markdown
Contributor Author

Absolutely! Feel free to take it over. I love this app and want to contribute in whatever way I can :)

@ykisana
ykisana force-pushed the test/admiring-wright-25r5wv branch from 701e927 to bc5643b Compare November 17, 2026 06:34
@ykisana ykisana changed the title Add haptic feedback when block status changes feat: add haptic feedback when blocking and unblocking Nov 17, 2026
@ykisana
ykisana force-pushed the test/admiring-wright-25r5wv branch 2 times, most recently from af6e032 to 1726e44 Compare November 17, 2026 06:54
@noahweidig
noahweidig force-pushed the test/admiring-wright-25r5wv branch from b0f4806 to 1726e44 Compare November 17, 2026 20:41
Play a medium impact haptic after a block or unblock goes through: Home,
group cards, links and widgets, Shortcuts and emergency unblock. It plays
from BlockActions after the change succeeds, so a failed unblock or a
cancelled key check plays nothing. Home's Block All Now now uses the same
path as Block All.

Co-authored-by: ykisana <ykisana@protonmail.com>
@ykisana
ykisana force-pushed the test/admiring-wright-25r5wv branch from 1726e44 to fd701b4 Compare November 18, 2026 03:58
ykisana added a commit that referenced this pull request Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so
cancelMain has no callers left. Its test goes with it; Block All Now's
behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks
and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
@ykisana
ykisana merged commit 0e9281a into normalengineering:main Nov 18, 2026
1 check passed
ykisana added a commit that referenced this pull request Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so
cancelMain has no callers left. Its test goes with it; Block All Now's
behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks
and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
ykisana added a commit that referenced this pull request Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so
cancelMain has no callers left. Its test goes with it; Block All Now's
behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks
and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
@noahweidig
noahweidig deleted the test/admiring-wright-25r5wv branch November 18, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants