Repository navigation
feat: add haptic feedback when blocking and unblocking - #115
Merged
ykisana merged 1 commit intoNov 18, 2026
Merged
Conversation
Contributor
|
Hey thanks for the contribution! Can you update this PR so it just has the haptic feedback, not the funding stuff. Also this will just update for main unblock/block all button. Maybe this should exist in the central blocking/unblocking logic. Also should add a setting in the settings to turn this on/off. I can take over this PR, sometime tmw if you don't have availability for these changes. |
Contributor
Author
|
Absolutely! Feel free to take it over. I love this app and want to contribute in whatever way I can :) |
ykisana
force-pushed
the
test/admiring-wright-25r5wv
branch
from
November 17, 2026 06:34
701e927 to
bc5643b
Compare
ykisana
force-pushed
the
test/admiring-wright-25r5wv
branch
2 times, most recently
from
November 17, 2026 06:54
af6e032 to
1726e44
Compare
noahweidig
force-pushed
the
test/admiring-wright-25r5wv
branch
from
November 17, 2026 20:41
b0f4806 to
1726e44
Compare
Play a medium impact haptic after a block or unblock goes through: Home, group cards, links and widgets, Shortcuts and emergency unblock. It plays from BlockActions after the change succeeds, so a failed unblock or a cancelled key check plays nothing. Home's Block All Now now uses the same path as Block All. Co-authored-by: ykisana <ykisana@protonmail.com>
ykisana
force-pushed
the
test/admiring-wright-25r5wv
branch
from
November 18, 2026 03:58
1726e44 to
fd701b4
Compare
ykisana
added a commit
that referenced
this pull request
Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so cancelMain has no callers left. Its test goes with it; Block All Now's behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
ykisana
added a commit
that referenced
this pull request
Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so cancelMain has no callers left. Its test goes with it; Block All Now's behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
ykisana
added a commit
that referenced
this pull request
Nov 18, 2026
Home's Block All Now goes through BlockActions.blockAll since #115, so cancelMain has no callers left. Its test goes with it; Block All Now's behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
BlockActionsplays it at the end ofblockAll,blockGroup,unblockandemergencyUnblock, so every path that changes what's blocked gets it.TimedUnblockService.cancelMaindirectly. It now calls Home'sblockMain, the sameBlockActions.blockAllas Block All, which already clears every timed unblock before blocking. The test harness'sblockAllNow()does the same.Tests
blockMain. The 21 Blocking ones, which include Block All Now, pass after it.