Skip to content

refactor: remove TimedUnblockService.cancelMain - #116

Merged
ykisana merged 1 commit into
mainfrom
chore/remove-cancel-main
Nov 18, 2026
Merged

ykisana merged 1 commit into
mainfrom
chore/remove-cancel-main

Conversation

@ykisana

@ykisana ykisana commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Removes TimedUnblockService.cancelMain and its unit test, cancelMainAppliesShieldsAndForgets.

Why

  • Since feat: add haptic feedback when blocking and unblocking #115, Home's Block All Now goes through BlockActions.blockAll like Block All, so cancelMain has no callers left.
  • Block All Now is still covered by BlockActionsTests.blockAllEndsTimedUnblocks and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.

Tests

  • Unit tests: 883/883 on the iPhone Air iOS 27.0 simulator.

@ykisana
ykisana force-pushed the chore/remove-cancel-main branch from 665c189 to 027ad88 Compare November 18, 2026 03:59
Home's Block All Now goes through BlockActions.blockAll since #115, so
cancelMain has no callers left. Its test goes with it; Block All Now's
behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks
and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
@ykisana
ykisana force-pushed the chore/remove-cancel-main branch from 027ad88 to bbbea9f Compare November 18, 2026 04:15
@ykisana
ykisana marked this pull request as ready for review November 18, 2026 04:15
@ykisana
ykisana merged commit 704622d into main Nov 18, 2026
1 check passed
@ykisana
ykisana deleted the chore/remove-cancel-main branch November 18, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant