Repository navigation
refactor: remove TimedUnblockService.cancelMain - #116
Merged
Merged
Conversation
ykisana
force-pushed
the
chore/remove-cancel-main
branch
from
November 18, 2026 03:59
665c189 to
027ad88
Compare
Home's Block All Now goes through BlockActions.blockAll since #115, so cancelMain has no callers left. Its test goes with it; Block All Now's behavior is still covered by BlockActionsTests.blockAllEndsTimedUnblocks and BlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.
ykisana
force-pushed
the
chore/remove-cancel-main
branch
from
November 18, 2026 04:15
027ad88 to
bbbea9f
Compare
ykisana
marked this pull request as ready for review
November 18, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TimedUnblockService.cancelMainand its unit test,cancelMainAppliesShieldsAndForgets.Why
BlockActions.blockAlllike Block All, socancelMainhas no callers left.BlockActionsTests.blockAllEndsTimedUnblocksandBlockingScenarioTests.blockAllNowEndsTheTimedUnblockAndBlocksEverything.Tests