Skip to content

refactor: require a passed key check to lift blocks - #101

Merged
ykisana merged 1 commit into
mainfrom
key-proof
Nov 13, 2026
Merged

ykisana merged 1 commit into
mainfrom
key-proof

Conversation

@ykisana

@ykisana ykisana commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Lifting a block now needs a KeyProof, which only a passed key or location check creates. "Block without key" gives none.

  • ProtectedAction is .tighten (bypass allowed) or .weaken (key required), replacing the separate allowBypass flag.
  • Unblocks and duration sheets take an UnblockGrant, which only exists if the proof covers the target, so a group key can't unblock all apps.
  • Turning off Prevent App Deletion or Block Adult Websites also needs a proof.

No behavior change.

Lifting a block now needs a KeyProof, which only a passed key or location check creates. ProtectedAction (.tighten/.weaken) replaces the separate allowBypass flag, and unblocks take an UnblockGrant that only exists when the proof covers the target.
@ykisana
ykisana merged commit 17ce1fa into main Nov 13, 2026
2 checks passed
@ykisana
ykisana deleted the key-proof branch November 13, 2026 23:06
ykisana added a commit that referenced this pull request Nov 13, 2026
Turning off Prevent App Deletion or Block Adult Websites now needs a key proof (#101). These UI tests check that turning either off asks for a key with no block-without-key option, and that turning the adult filter on still offers it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant