Repository navigation
test: cover turning off key-protected toggles - #102
Merged
Merged
Conversation
Turning off Prevent App Deletion or Block Adult Websites now needs a key proof (#101). These UI tests check that turning either off asks for a key with no block-without-key option, and that turning the adult filter on still offers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #101, which merged before these tests were pushed.
Turning off Prevent App Deletion or Block Adult Websites now needs a key proof. These UI tests cover that path, which nothing else did:
testTurningOffPreventAppDeleteNeedsAKey: after blocking, turning the toggle off asks for a key, offers no block-without-key option, and turns off once the key passes.testBlockAdultWebsitesTurnsOnWithoutAKeyAndOffWithOne: turning the filter on offers block-without-key; turning it off needs a key with no bypass.Tests only, no app code. Passed locally on the simulator (UI tests don't run in CI).