Skip to content

build: fix GCC warnings when building V8 with gnu++20 #67279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: fix GCC warnings when building V8 with gnu++20 #67279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,9 @@
'conditions': [
['clang==0 and OS!="win"', {
'cflags': [ '-Wno-restrict', ],
'cflags_cc': [
'-Wno-invalid-constexpr',
],
}],
# TODO(joyeecheung): investigate if it breaks addons.
# ['OS=="mac"', {
Expand Down
7 changes: 7 additions & 0 deletions tools/v8_gypfiles/toolchain.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@
# On by default in Clang and V8 requires it at least for arm64.
'-flax-vector-conversions',
],
'cflags_cc': [
# TODO(joyeecheung): this may be removed after we switch to C++23
'-Wno-invalid-constexpr',
# V8 uses the clang-only nodebug attribute in
# src/execution/simulator.h, which GCC ignores with a warning.
'-Wno-attributes',
],
}],
['clang==1 or OS!="win"', {
'cflags_cc': [
Expand Down
2 changes: 2 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@
}, '(OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
],
'cflags_cc': [
'-fvisibility-inlines-hidden'
],
}], # MSVC hides the non-public symbols by default so no need to configure it.
Expand Down
Loading