Repository navigation
build: fix GCC warnings when building V8 with gnu++20 - #67279
Open
joyeecheung wants to merge 1 commit into
Open
joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
This silences the following warning from GCC: - deps/v8/src/base/flags.h: call to non-constexpr function `std::__atomic_base<unsigned char>::operator unsigned char() const` in the defaulted `constexpr Flags::operator==` when instantiated with `std::atomic<uint8_t>` storage [-Winvalid-constexpr] - deps/v8/include/v8-wasm.h: call to non-constexpr function `std::unique_ptr<const unsigned char[]>::get() const` in `constexpr OwnedBuffer::as_span()` [-Winvalid-constexpr] - deps/v8/src/execution/simulator.h: ‘nodebug’ attribute directive ignored [-Wattributes] Also move -fvisibility-inlines-hidden from cflags to cflags_cc in tools/v8_gypfiles/v8.gyp to fix the following warning. cc1: warning: command-line option '-fvisibility-inlines-hidden' is valid for C++/ObjC++ but not for C Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
fix-warning
branch
from
November 5, 2026 16:31
43b3786 to
6f8984c
Compare
Member
Author
|
cc @nodejs/build @nodejs/v8-update |
jasnell
approved these changes
Nov 5, 2026
joyeecheung
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
lpinca
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This silences the following warning from GCC:
std::__atomic_base<unsigned char>::operator unsigned char() constin the defaultedconstexpr Flags::operator==when instantiated withstd::atomic<uint8_t>storage [-Winvalid-constexpr]std::unique_ptr<const unsigned char[]>::get() constinconstexpr OwnedBuffer::as_span()[-Winvalid-constexpr]Also move -fvisibility-inlines-hidden from cflags to cflags_cc in tools/v8_gypfiles/v8.gyp to fix the following warning.
cc1: warning: command-line option '-fvisibility-inlines-hidden' is
valid for C++/ObjC++ but not for C