Skip to content

Give the clip renderer the same delayRender budget the episode renderer has #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbrthirteen merged 1 commit into from
Aug 21, 2026
Merged

Give the clip renderer the same delayRender budget the episode renderer has #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions remotion/render-audiogram.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
*/

import { renderMedia, selectComposition } from "@remotion/renderer";

// Same reason as remotion/render.mjs: the 30s default is measured against
// the font delayRender competing with the whole bundle.
const DELAY_RENDER_TIMEOUT_MS = 120_000;
import { getCachedBundle } from "./bundle-cache.mjs";
import path from "path";
import fs from "fs";
Expand Down Expand Up @@ -80,6 +84,7 @@ async function main() {
onBundle: () => console.log(" Remotion: bundling (first run, or src/config changed)..."),
});
const composition = await selectComposition({
timeoutInMilliseconds: DELAY_RENDER_TIMEOUT_MS,
serveUrl: bundleLocation,
id: "Audiogram",
inputProps,
Expand All @@ -95,6 +100,7 @@ async function main() {
);

await renderMedia({
timeoutInMilliseconds: DELAY_RENDER_TIMEOUT_MS,
composition: { ...composition, durationInFrames, fps, width, height },
serveUrl: bundleLocation,
codec: "h264",
Expand Down
7 changes: 7 additions & 0 deletions remotion/render.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ function clampCaptionFontScale(raw) {
}


// Remotion's 30s default is measured against the font delayRender in Root.tsx,
// which competes with evaluating the whole bundle. That bundle has three
// compositions now, and the slowest CI runner does not finish inside 30s.
const DELAY_RENDER_TIMEOUT_MS = 120_000;

async function main() {
const opts = parseArgs();

Expand Down Expand Up @@ -197,6 +202,7 @@ async function main() {
serveUrl: bundleLocation,
id: "CaptionedClip",
inputProps,
timeoutInMilliseconds: DELAY_RENDER_TIMEOUT_MS,
});

const cpus = os.cpus().length;
Expand Down Expand Up @@ -227,6 +233,7 @@ async function main() {
outputLocation: captionOverlay,
inputProps,
concurrency,
timeoutInMilliseconds: DELAY_RENDER_TIMEOUT_MS,
onProgress: ({ progress }) => {
const pct = Math.round(progress * 100);
if (pct > lastPct + 9) {
Expand Down
Loading