Give the clip renderer the same delayRender budget the episode renderer has - #160
Conversation
…er has
Root.tsx holds the render open with delayRender("Waiting for DM Sans")
until the webfonts resolve, and that wait is measured against Remotion's
30s default while the whole bundle is evaluated alongside it. The bundle
gained a third composition and about a thousand lines this release, and
the Windows runner stopped finishing inside 30s: it timed out, fell
through to ASS, and the end-to-end render refuses that fallback.
render-full-episode.mjs already carried timeoutInMilliseconds: 120000 for
this, so the number is not new, only its reach. render.mjs is the path
every clip takes and never had it.
v2.6.0 renders all four styles on all three runners; main fails on
windows-latest twice in a row and passes on ubuntu and macos, which is
the shape of a budget that got tighter rather than something broken.
|
Warning Review limit reached
Next review available in: 2 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What this does
Blocks the v2.7.0 tag.
post-release-renderonmainfails onwindows-latesttwice in a row whileubuntuandmacospass; the same workflow on thev2.6.0tag passes on all three. That is a regression this release introduced.Root.tsxholds the render open withdelayRender("Waiting for DM Sans")until the webfonts resolve, and that wait is measured against Remotion's 30s default while the whole bundle is evaluated alongside it. The bundle gained a third composition and roughly a thousand lines this release. The slowest runner stopped finishing inside 30s: it timed out, loggedfalling back to ASS for this clip, andscripts/e2e_render.pycorrectly refuses that fallback.remotion/render-full-episode.mjsalready carriedtimeoutInMilliseconds: 120000for exactly this. The number is not new, only its reach.remotion/render.mjsis the path every clip takes and never had it;render-audiogram.mjsis new this release and did not either.How I tested it
post-release-renderdispatched on this branch: green on ubuntu, macos and windows, all four caption styles.For contrast, on
main: windows fails, twice. Onv2.6.0: all three pass.v2.6.0main(7c4d6f1)main(7c4d6f1), rerunChecklist
npx tsc --noEmitandnpm testpass (pluspytest tests/if you touched the backend)