Skip to content

Give the clip renderer the same delayRender budget the episode renderer has - #160

Merged
nmbrthirteen merged 1 commit into
mainfrom
fix/remotion-render-timeout
Aug 21, 2026
Merged

nmbrthirteen merged 1 commit into
mainfrom
fix/remotion-render-timeout

Conversation

@nmbrthirteen

Copy link
Copy Markdown
Owner

What this does

Blocks the v2.7.0 tag. post-release-render on main fails on windows-latest twice in a row while ubuntu and macos pass; the same workflow on the v2.6.0 tag passes on all three. That is a regression this release introduced.

Root.tsx holds the render open with delayRender("Waiting for DM Sans") until the webfonts resolve, and that wait is measured against Remotion's 30s default while the whole bundle is evaluated alongside it. The bundle gained a third composition and roughly a thousand lines this release. The slowest runner stopped finishing inside 30s: it timed out, logged falling back to ASS for this clip, and scripts/e2e_render.py correctly refuses that fallback.

remotion/render-full-episode.mjs already carried timeoutInMilliseconds: 120000 for exactly this. The number is not new, only its reach. remotion/render.mjs is the path every clip takes and never had it; render-audiogram.mjs is new this release and did not either.

How I tested it

post-release-render dispatched on this branch: green on ubuntu, macos and windows, all four caption styles.

For contrast, on main: windows fails, twice. On v2.6.0: all three pass.

ref ubuntu macos windows
v2.6.0 pass pass pass
main (7c4d6f1) pass pass fail
main (7c4d6f1), rerun pass pass fail
this branch pass pass pass

Checklist

  • npx tsc --noEmit and npm test pass (plus pytest tests/ if you touched the backend)
  • Docs updated if commands or behavior changed
  • No secrets, personal config, or generated output committed

…er has

Root.tsx holds the render open with delayRender("Waiting for DM Sans")
until the webfonts resolve, and that wait is measured against Remotion's
30s default while the whole bundle is evaluated alongside it. The bundle
gained a third composition and about a thousand lines this release, and
the Windows runner stopped finishing inside 30s: it timed out, fell
through to ASS, and the end-to-end render refuses that fallback.

render-full-episode.mjs already carried timeoutInMilliseconds: 120000 for
this, so the number is not new, only its reach. render.mjs is the path
every clip takes and never had it.

v2.6.0 renders all four styles on all three runners; main fails on
windows-latest twice in a row and passes on ubuntu and macos, which is
the shape of a budget that got tighter rather than something broken.
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nmbrthirteen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cd072e13-0e16-4e4e-950d-498aeb3eae5e

📥 Commits

Reviewing files that changed from the base of the PR and between 7c4d6f1 and 14044fd.

📒 Files selected for processing (2)
  • remotion/render-audiogram.mjs
  • remotion/render.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nmbrthirteen
nmbrthirteen merged commit f3ba985 into main Aug 21, 2026
17 checks passed
@nmbrthirteen
nmbrthirteen deleted the fix/remotion-render-timeout branch August 21, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant