[tiredunc]

Fixes #107. Room sync crashed on UNIQUE(project_id, name) in two ways: the host moved a name onto another address (split tail, swap, chain), or two functions shared an address (PS2 overlays) and a rename hit both. Whichever function holds a name now steps aside to its func_XXXXXXXX name until the host's name arrives, and a rename applies to the function that held the old name. Tested: three new regression tests in tests/test_collab.py fail without the fix and pass with it; ruff passes. Also ran live in a room on a PS2 project where the error used to repeat; it now syncs.

[ensapra]

The error still appears when reimporting a project with the old functions

[tiredunc]

Thanks for testing this. I think what your screenshot shows is a separate bug from this PR: #117 fixes the room sync (apply_remote_layout), but your log is from a reimport (the "Replacing project files and updating the function analysis" step), which runs different code (_import_split). I could reproduce the same message, UNIQUE constraint failed: functions.project_id, functions.name, by reimporting a PS2 project created on 1.0.6-alpha.3 with 1.0.6-alpha.4 plus this fix. The cause: reimport pairs old and new functions by address using a lookup that keeps one function per address, so a game whose overlay puts a second function at an address the main code already uses leaves one unpaired, and its name collides. I opened #123 for it. If you'd like to try it on your project, the branch is fix/reimport-overlay-twins on my fork.