Adapt gas tracker to follow the new block limits - #7286
Merged
Conversation
… supernova activation
sstanculeanu
marked this pull request as ready for review
October 14, 2025 09:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7286 +/- ##
=============================================================
- Coverage 75.68% 75.68% -0.01%
=============================================================
Files 860 860
Lines 141702 141727 +25
=============================================================
+ Hits 107248 107264 +16
- Misses 28514 28520 +6
- Partials 5940 5943 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdoAdoAdo
reviewed
Oct 14, 2025
| shardCoordinator: shardCoordinator, | ||
| gasHandler: gasHandler, | ||
| economicsFee: nil, | ||
| enableEpochsHandler: nil, |
Contributor
There was a problem hiding this comment.
this was changed in the feat/supernova-async-exec so probably will generate some conflicts
target the PR to the feat instead?
| } | ||
|
|
||
| return minGasPrice, gasPerDataByte, genesisTotalSupply, maxGasPriceSetGuardian, nil | ||
| // TODO[Sorin]: uncomment this once feat/supernova-async-exec merges with feat/sub-second-round |
Contributor
There was a problem hiding this comment.
if you retarget to feat/supernova-async-exec, the sub-second feat should already be merged.
Collaborator
Author
There was a problem hiding this comment.
updated after retarget
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
sstanculeanu
changed the base branch from
rc/supernova
to
feat/supernova-async-exec
October 15, 2025 06:41
…ersx/mx-chain-go into adapt-old-gas-tracker # Conflicts: # factory/processing/blockProcessorCreator.go # genesis/process/metaGenesisBlockCreator.go # genesis/process/shardGenesisBlockCreator.go # integrationTests/testProcessorNode.go # node/chainSimulator/components/coreComponents.go # process/block/preprocess/gasTracker_test.go # process/block/preprocess/rewardTxPreProcessor.go # process/block/preprocess/smartContractResults.go # process/block/preprocess/smartContractResults_test.go # process/block/preprocess/transactions.go # process/block/preprocess/transactionsV2_test.go # process/block/preprocess/transactions_test.go # process/block/shardblock_test.go # process/coordinator/process_test.go # process/errors.go # process/factory/metachain/preProcessorsContainerFactory.go # process/factory/metachain/preProcessorsContainerFactory_test.go # process/factory/shard/preProcessorsContainerFactory.go # process/factory/shard/preProcessorsContainerFactory_test.go
raduchis
self-requested a review
October 28, 2025 08:02
AdoAdoAdo
reviewed
Oct 28, 2025
raduchis
reviewed
Oct 28, 2025
raduchis
previously approved these changes
Oct 28, 2025
AdoAdoAdo
previously approved these changes
Oct 28, 2025
AdoAdoAdo
approved these changes
Oct 28, 2025
raduchis
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?