Gas tracker optimization

[sstanculeanu]

Reasoning behind the pull request

• avoid spamming epochs handler and rounds handler for each tx, initially reported here

Proposed changes

• implemented mechanism to only call them until supernova si active

Testing procedure

• with feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

❌ Patch coverage is 95.65217% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (6b86d8d) to head (a9eb2be).

Files with missing lines	Patch %	Lines
process/block/preprocess/gasTracker.go	89.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7420   +/-   ##
==========================================================
  Coverage                      77.45%   77.46%           
==========================================================
  Files                            869      869           
  Lines                         118182   118237   +55     
==========================================================
+ Hits                           91540    91587   +47     
- Misses                         20628    20635    +7     
- Partials                        6014     6015    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[axenteoctavian]

Just to keep in mind.
This logic assumes the overestimation factor is static and only needs to be computed once. But if in the future the overestimation factor becomes epoch-depended/dynamic then the gas tracker will never refresh the factor.

[sstanculeanu]

that's correct

[ssd04]

in the end this will be called will on each round, even if it will not call gt.economicsFee.BlockCapacityOverestimationFactor() anymore after activation, it's not computational heavy so not sure if it's a performance improvement compared to the other implementation

how many times per round will computeGasProvided be called? if it's only once per round, it might not be an improvement

not a strong optinion though

[sstanculeanu]

it was called once for each tx