Repository navigation
Read bus-reset generation from SelfIDCount, not reserved 0x06C - #215
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Contributor
Author
This was referenced Oct 22, 2026
Owner
|
Contributor
Author
I think... I should buy a sound thingy to make testing easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split of #213 (merge order):
Split out of #213 per review. At the busReset interrupt,
HandleInterruptread0x06C, which is reserved in the OHCI 1.2 register map.SelfIDCount.selfIDGeneration(bits 23:16) already holds the new generation at the reset edge (Table 11-2), which is what everyOnBusResetStarted(generation)consumer needs to drop old-generation work. Matches Apple's move to a new generation at the reset edge (IOFireWireController.cpp:1998-2000).No host test: none of the generation consumers are reachable from the interrupt fixture without a full SBP-2 rig. HW verification is the generation in the
[BusReset]/IRM log lines matching Self-ID. Affects stale-work handling for the whole controller, so a run with an audio device on the bus is welcome; I only have scanners.