Repository navigation
Bound SBP-2 max_payload by link speed, log posted-write fault address - #214
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Contributor
Author
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split of #213 (merge order):
Standalone fixes split out of #213.
max_payloadis now bounded by link speed (SBP-2 §5.1.2, Linuxsbp2.c:1169-1176): 512 B at S100, doubling per step, capped at 4096 and by our ownmax_rec. main emitted 4096 at S400. The 512-byte fallback when BusOptions is unreadable is logged.PostedWriteAddressHi/Lobefore the ack (Linuxohci.c:2121-2125), replacing the generic message.AsyncSubsystemLifecycleusesLinkControlBits::kRcvPhyPkt(bit 10). The local constant was bit 12, so teardown never cleared rcvPhyPkt.Host tests: new
FetchAgentTests.MaxPayloadRoundsDownAndRespectsLinkSpeed. HW: LS-9000 scan, to be run together with the other two split PRs.