SYNC-5090 - Remove probe-scraper for fxa-client #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
requested review from
Dexterp37,
akkomar,
badboy,
chutten,
mikaeld,
travis79 and
whd
as code owners
5 tasks
Contributor
Author
|
Here's the corresponding a-s PR: mozilla/application-services#7189 |
Member
|
Removal is ok, however it also needs to be removed as a dependency of Fenix then. |
bendk
force-pushed
the
push-wwxzutvuwtnu
branch
from
b3bfcdb to
466eb42
Compare
Contributor
Author
|
I removed the fenix dependency, but the CI is still failing. It seems like it's unrelated to my changes, but I'm not sure. |
badboy
force-pushed
the
push-wwxzutvuwtnu
branch
from
466eb42 to
49c7311
Compare
Member
I fixed that failure earlier on |
For this issue we're going to be removing the only metrics that fxa-client is using, so I guess it's time to remove this entry. An alternate approach could be to keep around an empty `metrics.yaml` file, that way we could add back metrics in the future without having to touch this repo. Either approach is fine with me, this one felt a bit cleaner though.
badboy
force-pushed
the
push-wwxzutvuwtnu
branch
from
49c7311 to
3366edf
Compare
badboy
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SYNC-5090 issue we're going to be removing the only metrics that fxa-client is using, so I guess it's time to remove this entry.
An alternate approach could be to keep around an empty
metrics.yamlfile, that way we could add back metrics in the future without having to touch this repo. Either approach is fine with me, this one felt a bit cleaner though.